Merge lp:~brendan-donegan/checkbox/bug886129_touch_as_mouse into lp:checkbox

Proposed by Brendan Donegan
Status: Merged
Merged at revision: 1124
Proposed branch: lp:~brendan-donegan/checkbox/bug886129_touch_as_mouse
Merge into: lp:checkbox
Diff against target: 36 lines (+7/-5)
2 files modified
debian/changelog (+2/-0)
jobs/input.txt.in (+5/-5)
To merge this branch: bzr merge lp:~brendan-donegan/checkbox/bug886129_touch_as_mouse
Reviewer Review Type Date Requested Status
Daniel Manrique (community) Approve
Review via email: mp+82264@code.launchpad.net

Description of the change

This change very simply adds 'device.category == TOUCH' as an accepted requirement for running the input/mouse test. At the moment some people with multitouch touchpads and touchscreens are getting the input devices category skipped, causing their system to get one star on the Ubuntu Friendly site.

I also took the opportunity to generalise the language used by the test to say 'pointing device' instead of 'mouse' specifically. If that's too controversial I can revert it.

This fix is for a bug that has been milestoned for the first Oneiric SRU so it would be good to get it merged ASAP

To post a comment you must log in.
Revision history for this message
Daniel Manrique (roadmr) wrote :

This looks OK, thanks! merging...

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2011-11-14 20:53:56 +0000
3+++ debian/changelog 2011-11-15 10:24:24 +0000
4@@ -40,6 +40,8 @@
5 (LP: #887964)
6 * Guard against trying to write files to logical partitions on USB sticks
7 (which will obviously fail) in usb_test (LP: #887049)
8+ * Allow input/mouse test to run if a TOUCH device is present
9+ (LP: #886129)
10
11 [ Javier Collado ]
12 * Broken job dependencies fixed (LP: #888447)
13
14=== modified file 'jobs/input.txt.in'
15--- jobs/input.txt.in 2011-10-07 18:59:33 +0000
16+++ jobs/input.txt.in 2011-11-15 10:24:24 +0000
17@@ -1,14 +1,14 @@
18 plugin: manual
19 name: input/mouse
20-requires: device.category == 'MOUSE'
21+requires: device.category == 'MOUSE' or device.category == 'TOUCH'
22 _description:
23 PURPOSE:
24- This test will test your mouse device
25+ This test will test your pointing device
26 STEPS:
27- 1. Move the mouse
28- 2. Perform some single/double/right click operations
29+ 1. Move the cursor using the pointing device or touch the screen.
30+ 2. Perform some single/double/right click operations.
31 VERIFICATION:
32- Did the mouse work as expected??
33+ Did the pointing device work as expected?
34
35 plugin: manual
36 name: input/keyboard

Subscribers

People subscribed via source and target branches