lp:~brendan-donegan/checkbox/bug1238570

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:checkbox at revision 2468

Daniel Manrique (community): Approve on 2013-10-23

Brendan Donegan (community): Needs Resubmitting on 2013-10-23

Diff: 106 lines (+44/-28)

2 files modified

checkbox-old/debian/changelog (+2/-0)
checkbox-old/scripts/network (+42/-28)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1238570: multiple multi_nic tests knock out networking when run on systems with more than one NIC

High

Fix Released

Link a bug report

Related blueprints

2450. By Brendan Donegan on 2013-10-23

Fix a few booboos

2449. By Brendan Donegan on 2013-10-23

Fix debug message

2448. By Brendan Donegan on 2013-10-23

Return if iperf command failed for some reason

2447. By Brendan Donegan on 2013-10-21

Refactor network script so that interfaces are reconnected even if the test fails or something else goes wrong

2446. By Brendan Donegan on 2013-10-16

scripts/network - restore other interfaces that were downed prior to running
the network test (LP: #1238570)

2445. By Daniel Manrique on 2013-10-16

" checkbox-old/plugins/backend_info.py: Fixes the relative path fix.

    We were doing os.path.realpath expansion in the wrong place, because,
    due to how checkbox variables work, string substitution was happening
    *after* realpathing the command's path. So first it'd be converted to an
    absolute path with the %(checkbox_share) intact, and *then*
    checkbox_share was being substituted by its value, thus having a double
    substitution.

    The fix defers os.path.realpath to a point where self.command is fully
    resolved and interpolated, so it constitutes an actual (either relative
    or absolute) path, thus guaranteeing os.path.realpath just turns that
    into an absolute path regardless.
 [r=brendan-donegan][bug=1240245][author=roadmr]"

2444. By Sylvain Pineau on 2013-10-16

"automatic merge by tarmac [r=zkrynicki,roadmr][bug=][author=sylvain-pineau]"

2443. By Daniel Manrique on 2013-10-15

"plugins/backend_info: Resolve and use full path to the backend script to ensure it runs when invoked via pkexec which is unhappy with relative paths (LP: #1240245)
 [r=cypressyew][bug=1240245][author=roadmr]"

2442. By Zygmunt Krynicki on 2013-10-15

"automatic merge by tarmac [r=roadmr][bug=][author=zkrynicki]"

2441. By Daniel Manrique on 2013-10-15

Fixed one-character packaging typo