Merge lp:~brendan-donegan/checkbox/bug1173103_user_interface_showSubmitToHexr into lp:checkbox

Proposed by Brendan Donegan
Status: Merged
Approved by: Zygmunt Krynicki
Approved revision: 2089
Merged at revision: 2089
Proposed branch: lp:~brendan-donegan/checkbox/bug1173103_user_interface_showSubmitToHexr
Merge into: lp:checkbox
Diff against target: 40 lines (+5/-3)
3 files modified
checkbox/user_interface.py (+2/-2)
checkbox_cli/cli_interface.py (+1/-1)
debian/changelog (+2/-0)
To merge this branch: bzr merge lp:~brendan-donegan/checkbox/bug1173103_user_interface_showSubmitToHexr
Reviewer Review Type Date Requested Status
Zygmunt Krynicki (community) Approve
Review via email: mp+161083@code.launchpad.net

Description of the change

There were a couple of latent issues left in some of the UI modules after the submitToHexr work. First, user_interface.py used the wrong keyword argument, and second cli_interface.py didn't return a tuple. This branch fixes both of these issues.

To post a comment you must log in.
Revision history for this message
Zygmunt Krynicki (zyga) wrote :

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'checkbox/user_interface.py'
2--- checkbox/user_interface.py 2013-04-24 13:45:51 +0000
3+++ checkbox/user_interface.py 2013-04-26 09:49:28 +0000
4@@ -131,8 +131,8 @@
5 def show_text(self, text, previous=None, next=None):
6 return
7
8- def show_entry(self, text, value, label=None, submitToHexr=False, previous=None, next=None):
9- return (value, submitToHexr)
10+ def show_entry(self, text, value, label=None, showSubmitToHexr=False, previous=None, next=None):
11+ return (value, False)
12
13 def show_check(self, text, options=[], default=[]):
14 return default
15
16=== modified file 'checkbox_cli/cli_interface.py'
17--- checkbox_cli/cli_interface.py 2013-04-24 13:45:51 +0000
18+++ checkbox_cli/cli_interface.py 2013-04-26 09:49:28 +0000
19@@ -345,7 +345,7 @@
20 def show_entry(self, text, value, showSubmitToHexr=False, label=None, previous=None, next=None):
21 dialog = CLILineDialog(text)
22
23- return dialog.run()
24+ return (dialog.run(), False)
25
26 def show_check(self, text, options=[], default=[]):
27 dialog = CLIChoiceDialog(text)
28
29=== modified file 'debian/changelog'
30--- debian/changelog 2013-04-25 20:25:06 +0000
31+++ debian/changelog 2013-04-26 09:49:28 +0000
32@@ -3,6 +3,8 @@
33 [ Brendan Donegan ]
34 * Add hidden 'Submit to HEXR' checkbox on submission screen, so that it can
35 be utilised in checkbox-certification.
36+ * checkbox/user_interface.py - fixed keyword argument in show_entry.
37+ checkbox_cli/cli_interface.py - return tuple as expected. (LP: #1173103)
38
39 [ Po-Hsu Lin]
40 * jobs/led.txt.in: Modified the description of led/power-blink-suspend test to

Subscribers

People subscribed via source and target branches