Merge lp:~brendan-donegan/checkbox/bug1149288 into lp:checkbox

[Brendan Donegan]

As noticed by CE QA, the sources-list test was broken by the changes to the sources_test script. This branch updates the test to get the parameters passed to the script as it expects.

[Daniel Manrique (roadmr)]

Looks OK, thanks!

One question, how are users supposed to define the parameters? using environment variables? just curious.

review: Approve

[Brendan Donegan (brendan-donegan)]

They're supposed to define them in the job command, so that you can have different tests for different sources lists

=== modified file 'data/whitelists/sniff.whitelist'
--- data/whitelists/sniff.whitelist	2013-01-02 21:59:05 +0000
+++ data/whitelists/sniff.whitelist	2013-03-06 13:29:31 +0000
@@ -33,3 +33,5 @@
 __suspend__
 suspend/suspend_advanced
 suspend/suspend-time-check
+__miscellanea__
+miscellanea/sources-list

=== modified file 'debian/changelog'
--- debian/changelog	2013-03-04 16:00:27 +0000
+++ debian/changelog	2013-03-06 13:29:31 +0000
@@ -4,6 +4,8 @@
   * Incremented version number.
   * scripts/sources_test - modified script so that it takes sources list
     location and repository list as arguments
+  * jobs/miscellanea.txt.in - provide REPOSITORY and SOURCES_LIST environment
+    variables to the sources_test script (LP: #1149288)
 
   [ Daniel Manrique ]
   * Added pipefail option to a few jobs using ansi_parser (LP: #1131598)

=== modified file 'jobs/miscellanea.txt.in'
--- jobs/miscellanea.txt.in	2013-01-07 08:53:00 +0000
+++ jobs/miscellanea.txt.in	2013-03-06 13:29:31 +0000
@@ -67,5 +67,5 @@
 
 plugin: shell
 name: miscellanea/sources-list
-command: sources_test
+command: sources_test $SOURCES_LIST "$REPOSITORIES"
 _description: Checks that a specified sources list file contains the requested repositories