Merge lp:~brendan-donegan/checkbox/bug1067692 into lp:checkbox

Proposed by Brendan Donegan
Status: Merged
Merged at revision: 1786
Proposed branch: lp:~brendan-donegan/checkbox/bug1067692
Merge into: lp:checkbox
Diff against target: 35 lines (+6/-1) (has conflicts)
2 files modified
debian/changelog (+5/-0)
jobs/suspend.txt.in (+1/-1)
Text conflict in debian/changelog
To merge this branch: bzr merge lp:~brendan-donegan/checkbox/bug1067692
Reviewer Review Type Date Requested Status
Marc Tardif (community) Approve
Review via email: mp+130566@code.launchpad.net

Description of the change

suspend_advanced doesn't need any dependencies other than power-management/rtc, so I've removed them.

To post a comment you must log in.
Revision history for this message
Marc Tardif (cr3) wrote :

Seems perfectly reasonable, nice troubleshooting!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2012-10-18 15:51:14 +0000
3+++ debian/changelog 2012-10-19 14:44:22 +0000
4@@ -10,6 +10,7 @@
5 * checkbox/lib/templates.py, jobs/resources.txt.in, jobs/wireless.txt.in,
6 jobs/suspend.txt.in - Don't try and coerce keys of resource jobs to
7 lowercase, as it upset the core of Checkbox (LP: #1067280)
8+<<<<<<< TREE
9 * jobs/suspend.txt.in - created new batch of wireless tests depending only on
10 suspend_advanced so that they will run in manual testing (LP: #1067678)
11 * scripts/resolution_test - Slightly clarify output of script so that it's
12@@ -17,6 +18,10 @@
13 * Allow verification and interaction to be used as aliases for manual tests
14 so that we can distinguish between tests which are partly manual and
15 those which are entirely manual.
16+=======
17+ * jobs/suspend.txt.in - Let suspend_advanced only depend on
18+ power-management/rtc (LP: #1067692)
19+>>>>>>> MERGE-SOURCE
20
21 [Daniel Manrique]
22 * [FEATURE] checkbox/job.py: Fixed intltool warning about unnamed
23
24=== modified file 'jobs/suspend.txt.in'
25--- jobs/suspend.txt.in 2012-10-17 10:42:35 +0000
26+++ jobs/suspend.txt.in 2012-10-19 14:44:22 +0000
27@@ -90,7 +90,7 @@
28
29 plugin: manual
30 name: suspend/suspend_advanced
31-depends: power-management/rtc suspend/network_before_suspend suspend/resolution_before_suspend suspend/wireless_before_suspend suspend/cpu_before_suspend suspend/memory_before_suspend
32+depends: power-management/rtc
33 requires:
34 package.name == 'fwts' or package.name == 'pm-utils'
35 sleep.mem == 'supported'

Subscribers

People subscribed via source and target branches