Merge lp:~brendan-donegan/checkbox/bug1065976 into lp:checkbox

Proposed by Brendan Donegan
Status: Merged
Merged at revision: 1783
Proposed branch: lp:~brendan-donegan/checkbox/bug1065976
Merge into: lp:checkbox
Diff against target: 25 lines (+4/-2)
2 files modified
debian/changelog (+2/-0)
scripts/resolution_test (+2/-2)
To merge this branch: bzr merge lp:~brendan-donegan/checkbox/bug1065976
Reviewer Review Type Date Requested Status
Marc Tardif (community) Approve
Review via email: mp+130307@code.launchpad.net

Description of the change

As mentioned in the bug, the text of the test is slightly confusing when it passes. This is just a minor tweak to clarify it.

To post a comment you must log in.
1783. By Brendan Donegan

Use the word display instead of monitor.

Revision history for this message
Marc Tardif (cr3) wrote :

I love it, thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2012-10-17 19:23:51 +0000
3+++ debian/changelog 2012-10-18 09:49:24 +0000
4@@ -10,6 +10,8 @@
5 * checkbox/lib/templates.py, jobs/resources.txt.in, jobs/wireless.txt.in,
6 jobs/suspend.txt.in - Don't try and coerce keys of resource jobs to
7 lowercase, as it upset the core of Checkbox (LP: #1067280)
8+ * scripts/resolution_test - Slightly clarify output of script so that it's
9+ a bit more obvious why it failed (LP: #1065976)
10
11 [Daniel Manrique]
12 * [FEATURE] checkbox/job.py: Fixed intltool warning about unnamed
13
14=== modified file 'scripts/resolution_test'
15--- scripts/resolution_test 2012-07-23 11:39:10 +0000
16+++ scripts/resolution_test 2012-10-18 09:49:24 +0000
17@@ -20,8 +20,8 @@
18 # Evaluate just the primary display
19 screen = Gdk.Screen.get_default()
20 geom = screen.get_monitor_geometry(screen.get_primary_monitor())
21- print("Expected monitor dimensions: %d x %d" % (min_h, min_v))
22- print("Detected monitor dimensions: %d x %d" % (geom.width, geom.height))
23+ print("Minimum acceptable display resolution: %d x %d" % (min_h, min_v))
24+ print("Detected display resolution: %d x %d" % (geom.width, geom.height))
25 return geom.width >= min_h and geom.height >= min_v
26
27

Subscribers

People subscribed via source and target branches