Merge lp:~brendan-donegan/checkbox/bug1052506 into lp:checkbox

[Brendan Donegan]

Make the Continue button the default and give it focus when Checkbox is loaded. Also I renamed the UI widget from 'friendlyTestsButton' to 'continueButton' as the previous name made little sense.

[lp:~brendan-donegan/checkbox/bug1052506]

1679. By Marc Tardif on 2012-09-19

Merged fix to bug #1052601 by bladernr.

1680. By Marc Tardif on 2012-09-19

Merged fix to bug #868643 by bladernr.

1681. By Marc Tardif on 2012-09-19

Merged fix to bug #990538 by bladernr.

1682. By Marc Tardif on 2012-09-19

Merged fix to bug #1053010 by bladernr.

1683. By Marc Tardif on 2012-09-19

Merged fix to bug #1053032 by bladernr.

1684. By Marc Tardif on 2012-09-19

Merged fix to bug #946184 by bladernr.

1685. By Marc Tardif on 2012-09-19

Merged fix to bug #1053033 by sylvain-pineau.

1686. By Brendan Donegan on 2012-09-20

qt/frontend/qtfront.ui, qt/frontend/qtfront.cpp - set focus to Continue
button and make it the default so that it can be 'clicked' using Enter,
as well as renaming it to 'continueButton' (LP: #1052506)

1687. By Brendan Donegan on 2012-09-20

Add UIFe to the commit message.

[Sylvain Pineau (sylvain-pineau)]

Tested with the Spacebar and Enter keys, works perfectly.

Thanks

review: Approve

=== modified file 'debian/changelog'
--- debian/changelog	2012-09-20 15:54:26 +0000
+++ debian/changelog	2012-09-20 21:36:19 +0000
@@ -105,6 +105,9 @@
   * jobs/wireless.txt.in - replace use of network_wireless_test in wireless_scanning
     with a simple Bash script using nmcli and delete network_wireless_test (LP: #900370)
   * jobs/audio.txt.in - fix description of audio/playback_hdmi (LP: #1052136)
+  * [UIFe] qt/frontend/qtfront.ui, qt/frontend/qtfront.cpp - set focus to Continue
+    button and make it the default so that it can be 'clicked' using Enter,
+    as well as renaming it to 'continueButton' (LP: #1052506)
 
   [Sylvain Pineau]
   * jobs/suspend.txt.in: Fixed suspend/suspend_advanced dependencies to avoid

=== modified file 'qt/frontend/qtfront.cpp'
--- qt/frontend/qtfront.cpp	2012-08-24 19:50:08 +0000
+++ qt/frontend/qtfront.cpp	2012-09-20 21:36:19 +0000
@@ -56,7 +56,7 @@
     ui->radioTestTab->setVisible(false);
     ui->nextPrevButtons->setVisible(false);
     ui->treeView->verticalScrollBar()->setTracking(true);
-    connect(ui->friendlyTestsButton, SIGNAL(clicked()), this, SLOT(onFullTestsClicked()));
+    connect(ui->continueButton, SIGNAL(clicked()), this, SLOT(onFullTestsClicked()));
     connect(ui->deselectAllButton, SIGNAL(clicked()), this, SLOT(onDeselectAllClicked()));
     connect(ui->selectAllButton, SIGNAL(clicked()), this, SLOT(onSelectAllClicked()));
     connect(ui->buttonStartTesting, SIGNAL(clicked()), this, SLOT(onStartTestsClicked()));
@@ -70,6 +70,7 @@
     connect(ui->treeView, SIGNAL(expanded(QModelIndex)), this, SLOT(onJobItemChanged(QModelIndex)));
     connect(ui->treeView, SIGNAL(clicked(QModelIndex)), this,  SLOT(onTestSelectionChanged()));
     connect(this, SIGNAL(testSelectionChanged()), this,  SLOT(onTestSelectionChanged()));
+    ui->continueButton->setFocus();
     ui->stepsFrame->setFixedHeight(0);
     ui->buttonSubmitResults->setEnabled(false);
     ui->submissionDataLineEdit->setEnabled(false);

=== modified file 'qt/frontend/qtfront.ui'
--- qt/frontend/qtfront.ui	2012-09-20 12:58:34 +0000
+++ qt/frontend/qtfront.ui	2012-09-20 21:36:19 +0000
@@ -187,7 +187,7 @@
              <bool>true</bool>
             </property>
            </widget>
-           <widget class="QPushButton" name="friendlyTestsButton">
+           <widget class="QPushButton" name="continueButton">
             <property name="geometry">
              <rect>
               <x>20</x>
@@ -204,6 +204,9 @@
             <property name="text">
              <string>Continue</string>
             </property>
+            <property name="default">
+             <bool>true</bool>
+            </property>
            </widget>
            <widget class="Line" name="line_3">
             <property name="geometry">