Merge lp:~brendan-donegan/checkbox/bug1016126_screenshot_after_suspend_base64 into lp:checkbox

Proposed by Brendan Donegan
Status: Merged
Merged at revision: 1450
Proposed branch: lp:~brendan-donegan/checkbox/bug1016126_screenshot_after_suspend_base64
Merge into: lp:checkbox
Diff against target: 24 lines (+4/-1)
2 files modified
debian/changelog (+3/-0)
jobs/suspend.txt.in (+1/-1)
To merge this branch: bzr merge lp:~brendan-donegan/checkbox/bug1016126_screenshot_after_suspend_base64
Reviewer Review Type Date Requested Status
Daniel Manrique (community) Approve
Review via email: mp+111436@code.launchpad.net

Description of the change

The screenshot.jpg and screenshot_fullscreen_video attachment jobs base64 encoded the attachments, which seems to have been the right thing to do in terms of checkbox processing them. screenshot_after_suspend.jpg neglected to though, so this merge fixes that.

To post a comment you must log in.
Revision history for this message
Daniel Manrique (roadmr) wrote :

Looks straightforward enough.

Thanks!

Merging..

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2012-06-20 16:10:42 +0000
3+++ debian/changelog 2012-06-21 16:08:25 +0000
4@@ -16,6 +16,9 @@
5 (LP: #1004212)
6 * Instead of checking output of nmcli con up in create_connection,
7 check the return code is success instead (LP: #1013537)
8+ * base64 encode the after suspend screenshot attachement so that it can
9+ be uploaded properly (LP: #1016126)
10+
11
12 [Marc Tardif]
13 * [FEATURE] Reworked media_keys_test into key_test, making it more generic
14
15=== modified file 'jobs/suspend.txt.in'
16--- jobs/suspend.txt.in 2012-06-18 16:04:36 +0000
17+++ jobs/suspend.txt.in 2012-06-21 16:08:25 +0000
18@@ -319,5 +319,5 @@
19 plugin: attachment
20 name: screenshot_after_suspend.jpg
21 depends: suspend/screenshot_after_suspend
22-command: cat ${CHECKBOX_DATA}/screenshot_after_suspend.jpg
23+command: base64 ${CHECKBOX_DATA}/screenshot_after_suspend.jpg
24 _description: Attaches the screenshot captured in graphics/screenshot.

Subscribers

People subscribed via source and target branches