Merge lp:~bregma/unity/lp-1100120 into lp:unity
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Brandon Schaefer | ||||
Approved revision: | no longer in the source branch. | ||||
Merged at revision: | 3524 | ||||
Proposed branch: | lp:~bregma/unity/lp-1100120 | ||||
Merge into: | lp:unity | ||||
Diff against target: |
20 lines (+2/-2) 1 file modified
unity-shared/OverlayRenderer.cpp (+2/-2) |
||||
To merge this branch: | bzr merge lp:~bregma/unity/lp-1100120 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Christopher Townsend | Approve | ||
Brandon Schaefer (community) | Approve | ||
PS Jenkins bot (community) | continuous-integration | Approve | |
Review via email: mp+186520@code.launchpad.net |
Commit message
render the Dash frame all the way to the bottom of the screen (lp: #1100120)
Description of the change
= Problem description =
The bottom of the Dash frame is not rendered all the way to the bottom of the screen (lp: 1100120).
= The fix =
The clipping area for the dash when not rendered in fullscreen mode was calculated incorrectly. This was adjusted.
= Test coverage =
There are no tests for this. I tried to come up with some way to verify clipping values, but there are just too many magic adjustment values hardcoded in the rendering code that any exposure of the base values would require insane adjustments in test code, which would just increase the maintenance nightmare factorially.
This is just one of those visual-confirmation of rendered graphics kind of verification situations.
Although the border does extend further towards the bottom of the screen/Launcher, I can still see a gap:(