Merge lp:~bregma/unity/lp-1051921-5.0 into lp:unity/5.0

Proposed by Stephen M. Webb on 2013-08-16
Status: Merged
Approved by: Brandon Schaefer on 2013-08-16
Approved revision: 2423
Merged at revision: 2423
Proposed branch: lp:~bregma/unity/lp-1051921-5.0
Merge into: lp:unity/5.0
Diff against target: 19 lines (+0/-3)
1 file modified
plugins/unityshell/src/DashStyle.cpp (+0/-3)
To merge this branch: bzr merge lp:~bregma/unity/lp-1051921-5.0
Reviewer Review Type Date Requested Status
Brandon Schaefer (community) 2013-08-16 Approve on 2013-08-16
Review via email: mp+180459@code.launchpad.net

Commit message

removed debug output thatcould cause a potential security problem (lp: #1051921)

Description of the change

Removes some debugging output that may pose a security problem, backported to Ubuntu 12.04.

No test case because functionality is unchanged, except the file /tmp/wut.png is no longer created when a list of selections in the HUD is drawn on the screen.

To post a comment you must log in.
Brandon Schaefer (brandontschaefer) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'plugins/unityshell/src/DashStyle.cpp'
2--- plugins/unityshell/src/DashStyle.cpp 2012-06-06 13:18:59 +0000
3+++ plugins/unityshell/src/DashStyle.cpp 2013-08-16 02:52:55 +0000
4@@ -1504,7 +1504,6 @@
5
6 // blur and blend overlay onto initial image-surface
7 Blur(blurred_cr, blurSize);
8- //cairo_surface_write_to_png(surface, "/tmp/overlay-surface.png");
9 cairo_set_source_surface(cr, surface, 0.0, 0.0);
10 old = SetBlendMode(cr, mode);
11 cairo_paint_with_alpha(cr, opacity);
12@@ -1724,8 +1723,6 @@
13 42.0 + 10.0,
14 alignment);
15
16- cairo_surface_write_to_png(cairo_get_target(cr), "/tmp/wut.png");
17-
18 return true;
19 }
20

Subscribers

People subscribed via source and target branches

to all changes: