Merge lp:~bregma/unity/fix-indicator-leaks into lp:unity
Status: | Needs review |
---|---|
Proposed branch: | lp:~bregma/unity/fix-indicator-leaks |
Merge into: | lp:unity |
Diff against target: |
164 lines (+35/-20) 5 files modified
services/CMakeLists.txt (+1/-1) services/panel-indicator-accessible.c (+6/-0) services/panel-indicator-accessible.h (+1/-0) services/panel-root-accessible.c (+12/-17) services/panel-service.c (+15/-2) |
To merge this branch: | bzr merge lp:~bregma/unity/fix-indicator-leaks |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Christopher Townsend | Needs Fixing | ||
PS Jenkins bot (community) | continuous-integration | Needs Fixing | |
Review via email: mp+187636@code.launchpad.net |
Commit message
dispose of ATK objects when indicators are removed (lp: #1231222)
Description of the change
= Problem description =
A circular ref between indicator objects and their ATK counterparts cause indicators to never get disposed, which shows up as nenory leaks on unity-panel-service shutdown. This makes it very difficult to spot other memory leaks.
= The fix =
Added a signal to dispose of the ATK objects before the indicator objects are removed.
= Test coverage =
Requires a manual test for verification: run unity-panel-service with the environment variable G_MESSAGES_
Unmerged revisions
- 3533. By Stephen M. Webb
-
broke some circular refs during shutdown to reduce memory leaks reported by valgrind (lp: #1231222)
- 3532. By Stephen M. Webb
-
unity-panel-
service: add debug domain
FAILED: Continuous integration, rev:3533 jenkins. qa.ubuntu. com/job/ unity-ci/ 396/ jenkins. qa.ubuntu. com/job/ unity-saucy- amd64-ci/ 285/console jenkins. qa.ubuntu. com/job/ unity-saucy- armhf-ci/ 283/console jenkins. qa.ubuntu. com/job/ unity-saucy- i386-ci/ 284/console
http://
Executed test runs:
FAILURE: http://
FAILURE: http://
FAILURE: http://
Click here to trigger a rebuild: s-jenkins: 8080/job/ unity-ci/ 396/rebuild
http://