Merge lp:~bregma/unity-system-compositor/lp-1677743 into lp:unity-system-compositor

Proposed by Stephen M. Webb
Status: Merged
Approved by: Stephen M. Webb
Approved revision: 310
Merged at revision: 309
Proposed branch: lp:~bregma/unity-system-compositor/lp-1677743
Merge into: lp:unity-system-compositor
Prerequisite: lp:~alan-griffiths/unity-system-compositor/compatibility
Diff against target: 15 lines (+0/-7)
1 file modified
src/com.canonical.Unity.conf (+0/-7)
To merge this branch: bzr merge lp:~bregma/unity-system-compositor/lp-1677743
Reviewer Review Type Date Requested Status
Brandon Schaefer (community) Approve
Alberto Aguirre (community) Approve
Mir CI Bot continuous-integration Approve
Review via email: mp+321507@code.launchpad.net

Commit message

src/com.canonical.Unity.conf: remove at_console policy stanza

Description of the change

Removes the at_console stanza from src/com.canonical.Unity.conf since it was deprecated years ago and its functionality has been removed from D-Bus, and it causes a nasty scary warning from Lintian during Deb packaging.

Doesn't seem to have any actual effect under test: screen still dims, turns off, and comes on. The at_console policy was really intended to allow users logged in to the physical console to be able to send and receive certain D-Bus messages so the stanza probably never had any effect anyway.

To post a comment you must log in.
Revision history for this message
Mir CI Bot (mir-ci-bot) wrote :

PASSED: Continuous integration, rev:310
https://mir-jenkins.ubuntu.com/job/usc-ci/63/
Executed test runs:
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-usc/86
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-0-fetch/4530
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/4520
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial+overlay/4520
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=zesty/4520
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-usc/arch=amd64,release=xenial+overlay/90
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-usc/arch=amd64,release=xenial+overlay/90/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-usc/arch=amd64,release=zesty/90
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-usc/arch=amd64,release=zesty/90/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-usc/arch=armhf,release=vivid+overlay/90
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-usc/arch=armhf,release=vivid+overlay/90/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-usc/arch=i386,release=xenial+overlay/90
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-usc/arch=i386,release=xenial+overlay/90/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-usc/arch=i386,release=zesty/90
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-usc/arch=i386,release=zesty/90/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://mir-jenkins.ubuntu.com/job/usc-ci/63/rebuild

review: Approve (continuous-integration)
Revision history for this message
Alberto Aguirre (albaguirre) wrote :

OK.

review: Approve
Revision history for this message
Brandon Schaefer (brandontschaefer) wrote :

I see no issues here

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/com.canonical.Unity.conf'
2--- src/com.canonical.Unity.conf 2016-05-24 13:56:28 +0000
3+++ src/com.canonical.Unity.conf 2017-03-31 02:37:14 +0000
4@@ -30,11 +30,4 @@
5 send_interface="org.freedesktop.DBus.Introspectable"/>
6 </policy>
7
8- <policy at_console="true">
9- <allow send_destination="com.canonical.Unity.Display"/>
10- <allow send_destination="com.canonical.Unity.Input"/>
11- <allow send_destination="com.canonical.Unity.PowerButton"/>
12- <allow send_destination="com.canonical.Unity.UserActivity"/>
13- </policy>
14-
15 </busconfig>

Subscribers

People subscribed via source and target branches