Unity Home Scope

Merge lp:~bregma/unity-scope-home/lp-1430063 into lp:unity-scope-home

  1. lp-1430063
  2. Merge into trunk
Proposed by Stephen M. Webb
Status: Merged
Approved by: Paweł Stołowski
Approved revision: 179
Merged at revision: 180
Proposed branch: lp:~bregma/unity-scope-home/lp-1430063
Merge into: lp:unity-scope-home
Prerequisite: lp:~bregma/unity-scope-home/lp-1430248
Diff against target: 12 lines (+1/-1)
1 file modified
src/smart-scopes-parse.vala (+1/-1)
To merge this branch: bzr merge lp:~bregma/unity-scope-home/lp-1430063
Reviewer Review Type Date Requested Status
Paweł Stołowski (community) Approve
PS Jenkins bot continuous-integration Pending
Review via email: mp+252435@code.launchpad.net

This proposal supersedes a proposal from 2015-03-09.

Commit message

initialized an uninitialized variable used in an "if" statement

Description of the change

Valac-0.26 (the default on Ubuntu "Vivid Vervet" dev release) is less tolerant of possibly uninitialized variables used as rvalues and flags an error. Initializing the variable eliminates the error.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:179
http://jenkins.qa.ubuntu.com/job/unity-scope-home-ci/107/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-scope-home-vivid-amd64-ci/1/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-scope-home-vivid-armhf-ci/1/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-scope-home-vivid-i386-ci/1/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-scope-home-ci/107/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Paweł Stołowski (stolowski) wrote :

I'm not sure what Jenkins is complaining about, but this change definitely looks good! Thanks!

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:179
http://jenkins.qa.ubuntu.com/job/unity-scope-home-ci/109/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-scope-home-vivid-amd64-ci/3/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-scope-home-vivid-armhf-ci/3/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-scope-home-vivid-i386-ci/3/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-scope-home-ci/109/rebuild

review: Needs Fixing (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/smart-scopes-parse.vala'
2--- src/smart-scopes-parse.vala 2013-05-03 18:51:00 +0000
3+++ src/smart-scopes-parse.vala 2015-03-10 13:52:30 +0000
4@@ -141,7 +141,7 @@
5 if (scope_elm_array.get_length () == 2)
6 {
7 var id = scope_elm_array.get_element (0).get_string ();
8- ScopeType tp;
9+ ScopeType tp = ScopeType.ClientScope;
10 bool invalid_type = false;
11
12 var type_str = scope_elm_array.get_element (1).get_string ();

Subscribers

People subscribed via source and target branches

to all changes: