Nux

Merge lp:~bregma/nux/fix-make-distcheck-failures into lp:nux

Proposed by Stephen M. Webb
Status: Merged
Approved by: Christopher Townsend
Approved revision: 777
Merged at revision: 782
Proposed branch: lp:~bregma/nux/fix-make-distcheck-failures
Merge into: lp:nux
Diff against target: 82 lines (+8/-6)
6 files modified
Nux/Makefile.am (+1/-0)
NuxCore/Makefile.am (+1/-0)
data/Makefile.am (+1/-1)
examples/Makefile.am (+1/-1)
gputests/Makefile.am (+1/-2)
tests/Makefile.am (+3/-2)
To merge this branch: bzr merge lp:~bregma/nux/fix-make-distcheck-failures
Reviewer Review Type Date Requested Status
Christopher Townsend (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+159635@code.launchpad.net

Commit message

fix failures in 'make distcheck' (lp: #1170358)

Description of the change

= Problem description =

"make distcheck" fails

= The fix =

Proper project hygiene has not been followed and the various makefiles have bitrotted. I had to add new files to distribution lists and new clean targets where appropriate.

= Test coverage =

Running 'make distcheck' should complete successfully.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Christopher Townsend (townsend) wrote :

make distcheck now passes with this merge.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'Nux/Makefile.am'
2--- Nux/Makefile.am 2012-12-04 19:36:00 +0000
3+++ Nux/Makefile.am 2013-04-18 13:55:29 +0000
4@@ -174,6 +174,7 @@
5 $(srcdir)/LayeredLayout.h \
6 $(srcdir)/Layout.h \
7 $(srcdir)/LinearLayout.h \
8+ $(srcdir)/MainLoopGLib.h \
9 $(srcdir)/Nux.h \
10 $(srcdir)/NuxGlobalInitializer.h \
11 $(srcdir)/Painter.h \
12
13=== modified file 'NuxCore/Makefile.am'
14--- NuxCore/Makefile.am 2012-12-04 19:36:00 +0000
15+++ NuxCore/Makefile.am 2013-04-18 13:55:29 +0000
16@@ -134,6 +134,7 @@
17 $(srcdir)/Color.h \
18 $(srcdir)/Colors.h \
19 $(srcdir)/Logger.h \
20+ $(srcdir)/LoggerPrivate.h \
21 $(srcdir)/LoggingWriter.h \
22 $(srcdir)/RollingFileAppender.h \
23 $(srcdir)/Memory.h \
24
25=== modified file 'data/Makefile.am'
26--- data/Makefile.am 2012-03-16 15:33:33 +0000
27+++ data/Makefile.am 2013-04-18 13:55:29 +0000
28@@ -1,5 +1,5 @@
29 # Please keep these in alphabetical order
30-PKGDATADIR="$(pkgdatadir)/@NUX_API_VERSION@"
31+PKGDATADIR=$(pkgdatadir)/@NUX_API_VERSION@
32
33 fontdir = $(PKGDATADIR)/Fonts
34 dist_font_DATA = \
35
36=== modified file 'examples/Makefile.am'
37--- examples/Makefile.am 2012-11-27 21:40:42 +0000
38+++ examples/Makefile.am 2013-04-18 13:55:29 +0000
39@@ -114,7 +114,7 @@
40 coverflow_SOURCES = coverflow.cpp
41 coverflow_LDADD = $(ALL_LIBS)
42
43-kinetic_scroll_view_SOURCES = kinetic_scroll_view.cpp TestButton.cpp
44+kinetic_scroll_view_SOURCES = kinetic_scroll_view.cpp TestButton.h TestButton.cpp
45 kinetic_scroll_view_LDADD = $(ALL_LIBS)
46
47 if HAVE_GEIS
48
49=== modified file 'gputests/Makefile.am'
50--- gputests/Makefile.am 2012-05-25 20:36:09 +0000
51+++ gputests/Makefile.am 2013-04-18 13:55:29 +0000
52@@ -53,7 +53,7 @@
53 arb_programs_limits_LDADD = $(ALL_LIBS)
54
55 # distribute source along to the documentation
56-sourcegputestsdir = "$(pkgdatadir)/gputests"
57+sourcegputestsdir = $(pkgdatadir)/gputests
58 sourcegputests_DATA = $(texture_power_of_2_SOURCES) \
59 $(framebufferobject_SOURCES) \
60 $(quad_2texmod) \
61@@ -61,6 +61,5 @@
62 $(texture_blur_SOURCES) \
63 $(texture_data_SOURCES) \
64 $(arb_programs_limits_SOURCES)
65-
66 endif
67
68
69=== modified file 'tests/Makefile.am'
70--- tests/Makefile.am 2013-03-12 14:05:14 +0000
71+++ tests/Makefile.am 2013-04-18 13:55:29 +0000
72@@ -395,8 +395,9 @@
73 | sed 's/>GTester Unit Test Report</>GTester Unit Test Report (normal)</' \
74 > test-nux-results.html )
75
76-clean-generic:
77- rm -f test-nux-results.xml test-nux-results.html
78+CLEANFILES = \
79+ test-nux-results.xml test-nux-results.html \
80+ gtest-nux-results.xml
81
82 .PHONY: check check-report full-report gtest test check-headless
83

Subscribers

People subscribed via source and target branches