Mir

Merge lp:~bregma/mir/lp-1504579 into lp:mir

Proposed by Stephen M. Webb
Status: Merged
Approved by: Daniel van Vugt
Approved revision: no longer in the source branch.
Merged at revision: 3013
Proposed branch: lp:~bregma/mir/lp-1504579
Merge into: lp:mir
Diff against target: 25 lines (+18/-0)
1 file modified
tools/valgrind_suppressions_generic (+18/-0)
To merge this branch: bzr merge lp:~bregma/mir/lp-1504579
Reviewer Review Type Date Requested Status
Daniel van Vugt Approve
Andreas Pokorny (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Alan Griffiths Approve
Review via email: mp+274003@code.launchpad.net

Commit message

Suppress some futex-related valgrind errors coming from libstdc++-v3 code on Linux (LP: #1504579)

Description of the change

Suppress some valgrind errors coming from libstdc++-v3 when doing Linux futex waits. These errors are causing CI failures on Wily.

To post a comment you must log in.
Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

*Tentative Approval* pending CI results

Looks plausible. So long as CI passes on the 32bit targets I approve.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Andreas Pokorny (andreas-pokorny) wrote :

ok

review: Approve
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Sure.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tools/valgrind_suppressions_generic'
2--- tools/valgrind_suppressions_generic 2015-04-28 07:54:10 +0000
3+++ tools/valgrind_suppressions_generic 2015-10-09 16:44:28 +0000
4@@ -12,3 +12,21 @@
5 fun:ioctl
6 fun:_ZN7android8EventHub16openDeviceLockedEPKc
7 }
8+{
9+ <kernel_ignores_futex_utime_if_not_required>
10+ Memcheck:Param
11+ futex(utime)
12+ fun:syscall
13+ fun:_ZNSt28__atomic_futex_unsigned_base19_M_futex_wait_until*
14+ ...
15+ fun:_M_load_and_test
16+}
17+{
18+ <kernel_ignores_futex_timeouts_if_not_required>
19+ Memcheck:Param
20+ futex(timeout)
21+ fun:syscall
22+ fun:_ZNSt28__atomic_futex_unsigned_base19_M_futex_wait_until*
23+ ...
24+ fun:_M_load_and_test
25+}

Subscribers

People subscribed via source and target branches