libgrip

Merge lp:~bregma/libgrip/lp-1266597 into lp:libgrip

  1. lp-1266597
  2. Merge into trunk
Proposed by Stephen M. Webb
Status: Merged
Approved by: Brandon Schaefer
Approved revision: 87
Merged at revision: 87
Proposed branch: lp:~bregma/libgrip/lp-1266597
Merge into: lp:libgrip
Diff against target: 21 lines (+2/-2)
1 file modified
examples/rectangle-mover/gesture.c (+2/-2)
To merge this branch: bzr merge lp:~bregma/libgrip/lp-1266597
Reviewer Review Type Date Requested Status
Brandon Schaefer (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+200614@code.launchpad.net

Commit message

Replace use of deprecated GTK+-3.0 function in example code.

Description of the change

= Problem description =

Project fails to build from source on Ubuntu "Trusty Tahr" because of deprecated GTK+ functions in example code.

= The fix =

Deprecated functions are replaced with GTK+-3.0 functions.

= Test coverage =

This is a build failure in example code. If it builds, it passes.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:87
http://jenkins.qa.ubuntu.com/job/libgrip-ci/7/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/libgrip-trusty-amd64-ci/1
    SUCCESS: http://jenkins.qa.ubuntu.com/job/libgrip-trusty-armhf-ci/1
    SUCCESS: http://jenkins.qa.ubuntu.com/job/libgrip-trusty-i386-ci/1

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/libgrip-ci/7/rebuild

review: Approve (continuous-integration)
lp:~bregma/libgrip/lp-1266597 updated
87. By Stephen M. Webb

replace deprecated GTK+ functions (lp: #1266597)

Revision history for this message
Brandon Schaefer (brandontschaefer) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'examples/rectangle-mover/gesture.c'
2--- examples/rectangle-mover/gesture.c 2012-02-02 16:53:26 +0000
3+++ examples/rectangle-mover/gesture.c 2014-01-07 00:44:14 +0000
4@@ -176,7 +176,7 @@
5 GtkWidget *tv;
6 GtkTreeModel *model;
7 GtkWidget *sw;
8- const GdkColor white = { 0, 0xffff, 0xffff, 0xffff };
9+ const GdkRGBA white = { 0, 0xffff, 0xffff, 0xffff };
10
11 app->da = gtk_drawing_area_new ();
12
13@@ -216,7 +216,7 @@
14
15 gtk_container_add (GTK_CONTAINER (window), hbox);
16
17- gtk_widget_modify_bg (app->da, GTK_STATE_NORMAL, &white);
18+ gtk_widget_override_background_color (app->da, GTK_STATE_NORMAL, &white);
19
20 g_signal_connect (app->da, "draw",
21 G_CALLBACK (draw_canvas), NULL);

Subscribers

People subscribed via source and target branches