Libertine

Merge lp:~bregma/libertine/fix-name into lp:libertine

  1. fix-name
  2. Merge into devel
Proposed by Stephen M. Webb
Status: Merged
Approved by: Christopher Townsend
Approved revision: 175
Merged at revision: 175
Proposed branch: lp:~bregma/libertine/fix-name
Merge into: lp:libertine
Diff against target: 18 lines (+3/-3)
1 file modified
data/libertine.desktop (+3/-3)
To merge this branch: bzr merge lp:~bregma/libertine/fix-name
Reviewer Review Type Date Requested Status
Christopher Townsend Approve
Libertine CI Bot continuous-integration Approve
Review via email: mp+286902@code.launchpad.net

Commit message

remove the unnecessary quotes from the .desktop file

Description of the change

Remove the unnecessary quotes from the .desktop file.

To post a comment you must log in.
Revision history for this message
Libertine CI Bot (libertine-ci-bot) wrote :

PASSED: Continuous integration, rev:175
https://jenkins.canonical.com/libertine/job/libertine-ci-verify-mp/116/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/libertine/job/generic-ci-generate-dsc/119
    SUCCESS: https://jenkins.canonical.com/libertine/job/libertine-ci-build-and-test-dsc/architecture=amd64,distribution=vivid,label_exp=jenkins-slave-0%20%7C%7C%20jenkins-slave-2/78
    SUCCESS: https://jenkins.canonical.com/libertine/job/libertine-ci-build-and-test-dsc/architecture=amd64,distribution=xenial,label_exp=jenkins-slave-0%20%7C%7C%20jenkins-slave-2/78
    SUCCESS: https://jenkins.canonical.com/libertine/job/libertine-ci-build-and-test-dsc/architecture=i386,distribution=vivid,label_exp=jenkins-slave-0%20%7C%7C%20jenkins-slave-2/78
    SUCCESS: https://jenkins.canonical.com/libertine/job/libertine-ci-build-and-test-dsc/architecture=i386,distribution=xenial,label_exp=jenkins-slave-0%20%7C%7C%20jenkins-slave-2/78
    None: https://jenkins.canonical.com/libertine/job/libertine-ci-update-mp/1014/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/libertine/job/libertine-ci-verify-mp/116/rebuild

review: Approve (continuous-integration)
Revision history for this message
Christopher Townsend (townsend) wrote :

Although I like the quotes since it makes it more libertine, I agree that no quotes is the Right Thing To Do:)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'data/libertine.desktop'
2--- data/libertine.desktop 2015-08-04 19:32:16 +0000
3+++ data/libertine.desktop 2016-02-23 14:23:15 +0000
4@@ -1,11 +1,11 @@
5 [Desktop Entry]
6 Version=1.0
7-Name="Libertine"
8-Comment="Legacy Application Sandbox"
9+Name=Libertine
10+Comment=Legacy Application Sandbox
11 Exec=libertine
12 Terminal=false
13 Type=Application
14 Icon=/usr/share/libertine/libertine_64.png
15 Categories=
16-GenericName="Application Sandbox"
17+GenericName=Application Sandbox
18 X-Ubuntu-Touch=true

Subscribers

People subscribed via source and target branches