Code review comment for lp:~bregma/ginn/build-with-werror

Revision history for this message
Jussi Pakkanen (jpakkane) wrote :

Looks good. The only comment I have is that a __attribute__((unused)) is a GCCism, it should be used through a #define. Something like this:

---- some header ----

#define UNUSED __attribute__((unused))

---------------------

---- Elsewhere -----

gesture_match(GeisGestureType gesture_type,
 GeisGestureId gesture_id UNUSED,
 GeisSize attr_count UNUSED,
 GeisGestureAttr * attrs, int state)

--------------------

« Back to merge proposal