Code review comment for lp:~bregma/geis/lp-987539

Revision history for this message
Daniel d'Andrada (dandrader) wrote :

I think _geis_grail_add_device() function is getting way too long. It would be better put that code into a separate helper function[1] and call it from _geis_grail_add_device().

[1] - e.g. _gbe_add_device_axes_attributes(geis_device, frame_device)

-------

testsuite/geis2/gtest_devices.cpp:185

 * This test creates a devicve with known X and Y extents and verifies the

s/devicve/device
and probably (not a native speaker myself)
s/verifies/verifies that

review: Needs Fixing

« Back to merge proposal