Merge lp:~bregma/geis/lp-964469 into lp:geis

Proposed by Stephen M. Webb
Status: Merged
Approved by: Brandon Schaefer
Approved revision: 312
Merged at revision: 317
Proposed branch: lp:~bregma/geis/lp-964469
Merge into: lp:geis
Diff against target: 29 lines (+10/-7)
1 file modified
tools/geisview/defaults.py.in (+10/-7)
To merge this branch: bzr merge lp:~bregma/geis/lp-964469
Reviewer Review Type Date Requested Status
Brandon Schaefer (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+161861@code.launchpad.net

Commit message

Fix error message(s) in "help" dialog (lp: #964469).

Description of the change

= Problem description =

geisview crashed with AttributeError in on_menu_item_about(): 'module' object has no attribute 'license'
(lp: #964469)

= The fix =

Fix variable names used reflectively in geisview tool "about" dialog.

= Test coverage =

No automated tests available. Run the geisview tool and click on the 'Help' menu, it should just work.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Brandon Schaefer (brandontschaefer) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tools/geisview/defaults.py.in'
2--- tools/geisview/defaults.py.in 2012-12-04 12:39:16 +0000
3+++ tools/geisview/defaults.py.in 2013-05-01 15:58:27 +0000
4@@ -45,16 +45,19 @@
5 copyright = 'Copyright 2011 Canonical, Ltd.'
6 description = _("A GEIS data viewer.\n\nGEIS Viewer is a part of "
7 "the Canonical gesture recognition stack.")
8-authors = ["Stephen M. Webb <stephen.webb@canonical.com"]
9+authors = ["Stephen M. Webb &lt;stephen.webb@canonical.com&gt;"]
10+translator_credit = u''
11
12-LICENSE = _("%s is free software; you can redistribute it and/or modify "
13- "it under the terms of version 3 of the GNU General Public License "
14- "as published by the Free Software Foundation.\n\n").replace("%s", appname),
15+license = "{} {} {}".format(_(u"%s is free software; you can redistribute "
16+ "it and/or modify it under the terms of version 3 of the GNU General "
17+ "Public License "
18+ "as published by the Free Software Foundation.\n\n").replace("%s",
19+ appname),
20 _("%s is distributed in the hope that it will be useful, "
21 "but WITHOUT ANY WARRANTY; without even the implied warranty of "
22 "MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the "
23- "GNU General Public License for more details.\n\n").replace("%s", appname),
24+ "GNU General Public License for more details.\n\n").replace("%s",
25+ appname),
26 _("You should have received a copy of the GNU General Public License "
27- "along with this program. If not, see <http://www.gnu.org/licenses/>.")
28-
29+ "along with this program. If not, see <http://www.gnu.org/licenses/>."))
30

Subscribers

People subscribed via source and target branches