Code review comment for lp:~bregma/geis/lp-891731

Revision history for this message
Chase Douglas (chasedouglas) wrote :

The comment is good. I didn't really understand what the test was doing until now.

I think the test case would be easier to run if it did the following:

1. If a direct touch device is found, print a message like "SKIP (Reason: Touchscreen device must not be present)", then exit.

2. If an indirect touch device also is not found, print a message like "SKIP (Reason: Indirect touch device must be present)", then exit.

3. Prompt the user with something like: "Place two touches on an attached multitouch device. An error will be printed if the test fails. If no message is printed, the test passed."

For extra kudos, you could detect the devices, and if one class is present and the other is missing you could then do the subscription for the missing class. This would allow testing on a tablet, for example.

review: Needs Fixing

« Back to merge proposal