Merge lp:~bregma/evemu/lp-1152774 into lp:evemu

Proposed by Stephen M. Webb on 2013-03-08
Status: Needs review
Proposed branch: lp:~bregma/evemu/lp-1152774
Merge into: lp:evemu
Diff against target: 9 lines (+1/-1)
1 file modified
python/evemu/const.py (+1/-1)
To merge this branch: bzr merge lp:~bregma/evemu/lp-1152774
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve on 2013-03-12
Mathieu Trudel-Lapierre (community) 2013-03-08 Needs Information on 2013-03-11
Review via email: mp+152526@code.launchpad.net

Commit message

Fix python bindings crash (lp: #1152774).

Description of the change

= Problem description =

Using the evemu python bindings results in a crash unless the libevemu-dev package is installed.

= The fix =

The python bindings need to use the proper search string for the DSO.

= Test coverage =

It is not possible to provide an automated test since this situation does not occur in the build environment.

To post a comment you must log in.
Mathieu Trudel-Lapierre (cyphermox) wrote :

We should double check that the libevemu-dev package also gets in the depends for the python bindings, in case this isn't explicitly what you're fixing here.

Stephen M. Webb (bregma) wrote :

The point is that the python-evemu runtime binary package should _not_ require the libevemu-dev development binary package in order to run without crashing. Adding a package dependency is wrong; fixing the DSO search string in the python bindings is the only change required.

Mathieu Trudel-Lapierre (cyphermox) wrote :

Please also add the Depends to python-evemu in debian/control.

review: Needs Fixing
Mathieu Trudel-Lapierre (cyphermox) wrote :

Disregard my message. Still you should consider having it in Suggest/Recommends depending on how important it is to get some of the features of evemu.

Consider this: how else are people expected to get the DSO installed? Is it depended on elsewhere? In which case you can ask whether a package that build-depends on both really should, or if it's python-evemu's job to pull it if it's needed.

review: Needs Information
Mathieu Trudel-Lapierre (cyphermox) wrote :

Could you at least add an integration test or autopkgtests to make sure the package works with the changes? (and verifying the fix)

I care little about the DSO/depends change itself, just make sure people get the right package they need to do whatever they need to do. If they may need to have the shared lib installed, then we should provide a way that it's clear the lib may be needed.

Unmerged revisions

68. By Stephen M. Webb on 2013-03-08

Fix crash when using python bindings without the -dev package installed (lp: #1152774).

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'python/evemu/const.py'
2--- python/evemu/const.py 2012-07-05 17:12:59 +0000
3+++ python/evemu/const.py 2013-03-08 22:36:20 +0000
4@@ -1,4 +1,4 @@
5-LIB = "libevemu.so"
6+LIB = "evemu"
7 DEFAULT_LIB = "/usr/lib/libevemu.so"
8 LOCAL_LIB = "../src/.libs/libevemu.so"
9 UINPUT_NODE = "/dev/uinput"

Subscribers

People subscribed via source and target branches