Compiz

Merge lp:~bregma/compiz/lp-1101630 into lp:compiz/0.9.12

  1. lp-1101630
  2. Merge into 0.9.12
Proposed by Stephen M. Webb
Status: Merged
Approved by: Christopher Townsend
Approved revision: 3890
Merged at revision: 3900
Proposed branch: lp:~bregma/compiz/lp-1101630
Merge into: lp:compiz/0.9.12
Diff against target: 13 lines (+2/-1)
1 file modified
plugins/animation/src/animation.cpp (+2/-1)
To merge this branch: bzr merge lp:~bregma/compiz/lp-1101630
Reviewer Review Type Date Requested Status
Christopher Townsend (community) Approve
PS Jenkins bot continuous-integration Pending
Review via email: mp+240157@code.launchpad.net

Commit message

animation plugin: initialize mPrevAnimSelectionRow

Description of the change

Initialized a member variable in the animations plugin. Not sure if there are code paths that can use it uninitialized or not, better to be safe than sorry. Makes Coverity happy (see bug).

To post a comment you must log in.
Revision history for this message
Christopher Townsend (townsend) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'plugins/animation/src/animation.cpp'
2--- plugins/animation/src/animation.cpp 2013-10-30 20:31:20 +0000
3+++ plugins/animation/src/animation.cpp 2014-10-30 19:15:49 +0000
4@@ -2905,7 +2905,8 @@
5 mDestroyCnt (0),
6 mIgnoreDamage (false),
7 mFinishingAnim (false),
8- mCurAnimSelectionRow (-1)
9+ mCurAnimSelectionRow (-1),
10+ mPrevAnimSelectionRow (-1)
11 {
12 mBB.x1 = mBB.y1 = MAXSHORT;
13 mBB.x2 = mBB.y2 = MINSHORT;

Subscribers

People subscribed via source and target branches