Code review comment for lp:~bratsche/oif/evince-move-gestures-into-view

Revision history for this message
Stephen M. Webb (bregma) wrote :

Please use symbolic constants for threshold values (eg. "drag->velocity_y >= 1.0", "rotate->angle >= 1.0", etc) to (a) make the code more self-documenting and (2) make it easier to find the values to tweak later during the tweak phase.

Other than that, this code looks good. I am unable to build it at the moment to do run-time evaluation.

review: Needs Fixing

« Back to merge proposal