Code review comment for lp:~bratsche/oif/eog-rotate-gesture-2

Revision history for this message
Stephen M. Webb (bregma) wrote :

I would suggest using a constant instead of hard-coded 1.0 in "rotate->angle >= 1.0" and "rotate->angle <= -1.0" so they can be tweaked a little easier when we figure out better threshold values, and so they can be a little more self-documenting.

Other than that, this change looks clean.

review: Approve

« Back to merge proposal