Merge lp:~bratsche/indicator-application/assemblyinfo into lp:indicator-application/0.4
| Status: | Merged |
|---|---|
| Merged at revision: | not available |
| Proposed branch: | lp:~bratsche/indicator-application/assemblyinfo |
| Merge into: | lp:indicator-application/0.4 |
| Diff against target: |
47 lines (+31/-1) 2 files modified
bindings/mono/AssemblyInfo.cs (+30/-0) bindings/mono/Makefile.am (+1/-1) |
| To merge this branch: | bzr merge lp:~bratsche/indicator-application/assemblyinfo |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Ted Gould (community) | 2010-04-14 | Approve on 2010-04-14 | |
|
Review via email:
|
|||
| Ted Gould (ted) wrote : | # |
| Cody Russell (bratsche) wrote : | # |
Yeah, but I don't think we should. VERSION is set to 0.0.18 (or whatever), so every time there is a release the assembly version would get bumped. It should be tracking a more stable version I think, otherwise I think each time we bump the version all apps that are using it would need to rebuild.
| Ted Gould (ted) wrote : | # |
On Wed, 2010-04-14 at 16:24 +0000, Cody Russell wrote:
> Yeah, but I don't think we should. VERSION is set to 0.0.18 (or
> whatever), so every time there is a release the assembly version
> would get bumped. It should be tracking a more stable version I
> think, otherwise I think each time we bump the version all apps
> that are using it would need to rebuild.
Ah, okay. We should probably introduce something like APIVERSION or
something for the pkgconfig files as well.
review approve

Is there a way that we can use $VERSION for the version in here? "$VERSION" in the C world.
Something like a -DVERSION=