Merge lp:~bratsche/appmenu-gtk/show-local into lp:appmenu-gtk/0.4

Proposed by Cody Russell
Status: Merged
Merged at revision: 63
Proposed branch: lp:~bratsche/appmenu-gtk/show-local
Merge into: lp:appmenu-gtk/0.4
Diff against target: 0 lines
To merge this branch: bzr merge lp:~bratsche/appmenu-gtk/show-local
Reviewer Review Type Date Requested Status
David Barth (community) Approve
Review via email: mp+30640@code.launchpad.net

Description of the change

There is still an issue where the application may draw the menu before it receives a response from dbus, and will then hide it if the dbus response was successful.

For now I'm not sure the best way to fix that, so I'm deferring that to another branch for now. This branch solves enough problems that I think we should get it into this release despite that flaw.

To post a comment you must log in.
lp:~bratsche/appmenu-gtk/show-local updated
62. By Cody Russell

Remove 'failed' as we don't need that anymore.

Revision history for this message
David Barth (dbarth) wrote :

+1 after you explained how that depends on an updated GTK patch to do the rest of the work.

review: Approve
Revision history for this message
Cody Russell (bratsche) wrote :

When the async dbus callback is received, it sets the show-local property to TRUE or FALSE. Then gtk+ updates the menubar visibility accordingly.

lp:~bratsche/appmenu-gtk/show-local updated
63. By Cody Russell

Merge up with trunk

Preview Diff

Empty

Subscribers

People subscribed via source and target branches