Merge lp:~bratsche/appmenu-gtk/menubar-visibility into lp:appmenu-gtk/0.4

Proposed by Cody Russell
Status: Merged
Merged at revision: 64
Proposed branch: lp:~bratsche/appmenu-gtk/menubar-visibility
Merge into: lp:appmenu-gtk/0.4
Diff against target: 18 lines (+2/-2)
1 file modified
src/bridge.c (+2/-2)
To merge this branch: bzr merge lp:~bratsche/appmenu-gtk/menubar-visibility
Reviewer Review Type Date Requested Status
Ken VanDine Approve
Review via email: mp+30731@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Ken VanDine (ken-vandine) wrote :

Looks great

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/bridge.c'
2--- src/bridge.c 2010-07-22 13:15:29 +0000
3+++ src/bridge.c 2010-07-23 00:12:45 +0000
4@@ -338,12 +338,12 @@
5 {
6 if (strlen (new) > 0 && strlen (prev) == 0)
7 {
8- if (g_strcmp0 (name, APP_MENU_DBUS_NAME) == 0)
9+ if (g_strcmp0 (name, APP_MENU_DBUS_NAME) == 0 && (prev == NULL || strlen (prev) == 0))
10 {
11 app_menu_bridge_proxy_appeared (bridge);
12 }
13 }
14- else if (strlen (new) == 0 && strlen (prev) > 0)
15+ else if (g_strcmp0 (name, APP_MENU_DBUS_NAME) == 0 && strlen (new) == 0 && strlen (prev) > 0)
16 {
17 app_menu_bridge_proxy_vanished (bridge);
18 }

Subscribers

People subscribed via source and target branches