Code review comment for lp:~brandontschaefer/unity/possible-crash--fixes

Marco Trevisan (TreviƱo) (3v1n0) wrote :

> So im tracking down the crash that wasn't fixed by this branch. Here are the
> only 2 crashes now from UnityPlugin and Wobbly Windows:
>
> Caused when enabling/disabling Unity Plugin in ccsm
> bamf_matcher_on_view_opened:
>
> normal backtrace
> http://paste.ubuntu.com/943691/
>
> full backtrace
> http://paste.ubuntu.com/943693/
>
> Caused when enabling/disabling Wobbly Windows in ccsm
> bamf_matcher_on_view_closed:
>
> normal backtrace
> http://paste.ubuntu.com/943698/
>
> full backtrace
> http://paste.ubuntu.com/943697/
>
>
> What happens is either OpenView is emited twice on the same window or the
> CloseView is called twice on the same window. It was always the same window
> for open, or the same for close (if you cause the crash multiple times).

This should be due to libbamf, that doesn't disconnect these signals on dispose, I'll look to that.

The unity side looks good to me.

review: Approve

« Back to merge proposal