Merge lp:~brandontschaefer/unity/overlay-scrollbar-filter-results-fix into lp:~unity-team/unity/libunity-7.0-breakage

Proposed by Brandon Schaefer
Status: Merged
Approved by: Nick Dedekind
Approved revision: no longer in the source branch.
Merged at revision: 3094
Proposed branch: lp:~brandontschaefer/unity/overlay-scrollbar-filter-results-fix
Merge into: lp:~unity-team/unity/libunity-7.0-breakage
Diff against target: 20 lines (+1/-2)
1 file modified
dash/ScopeView.cpp (+1/-2)
To merge this branch: bzr merge lp:~brandontschaefer/unity/overlay-scrollbar-filter-results-fix
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Nick Dedekind (community) Approve
Review via email: mp+155026@code.launchpad.net

Commit message

The FilterResults was using the PlacesVScrollbar which doesn't have the Overlayscroll bar. So just change it to use PlacesOverlayVScrollbar.

Description of the change

The FilterResults was using the PlacesVScrollbar which doesn't have the Overlayscroll bar. So just change it to use PlacesOverlayVScrollbar.

To post a comment you must log in.
Revision history for this message
Nick Dedekind (nick-dedekind) wrote :

I've seen the bug.
LGTM.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'dash/ScopeView.cpp'
2--- dash/ScopeView.cpp 2013-03-20 11:25:53 +0000
3+++ dash/ScopeView.cpp 2013-03-22 17:58:19 +0000
4@@ -32,7 +32,6 @@
5 #include "ResultRendererHorizontalTile.h"
6 #include "unity-shared/UBusMessages.h"
7 #include "unity-shared/UBusWrapper.h"
8-#include "unity-shared/PlacesVScrollBar.h"
9 #include "unity-shared/PlacesOverlayVScrollBar.h"
10 #include "unity-shared/GraphicsUtils.h"
11
12@@ -260,7 +259,7 @@
13 no_results_->SetVisible(false);
14 scroll_layout_->AddView(no_results_, 1, nux::MINOR_POSITION_CENTER, nux::MINOR_SIZE_MATCHCONTENT);
15
16- fscroll_view_ = new ScopeScrollView(new PlacesVScrollBar(NUX_TRACKER_LOCATION), NUX_TRACKER_LOCATION);
17+ fscroll_view_ = new ScopeScrollView(new PlacesOverlayVScrollBar(NUX_TRACKER_LOCATION), NUX_TRACKER_LOCATION);
18 fscroll_view_->EnableVerticalScrollBar(true);
19 fscroll_view_->EnableHorizontalScrollBar(false);
20 fscroll_view_->SetVisible(false);

Subscribers

People subscribed via source and target branches