Merge lp:~brandontschaefer/unity/lp1085045-fix-title-not-updating into lp:unity

[Brandon Schaefer]

Panel title is now being set when in KeyNav mode.

=== Problem ===
When going into KeyNav mode through Alt+F1 the panel title was not being updated to reflect the icon name.

The panel_title was being set to the icon name, but after that in Refresh a check if _panel_title == new_title was always returning true. This is because GetCurrentTitle would reutrn the _panel_title if in keynav more or in switcher mode. So _panel_title == _panel_title....

=== Fix ===
The fix is to skip GetCurrentTitle when in keynav or switch mode because it is already getting set.

=== Test ===
There is a nice simple AP test for this.

[Stephen M. Webb (bregma)]

Excellent.

review: Approve

=== modified file 'panel/PanelMenuView.cpp'
--- panel/PanelMenuView.cpp	2012-11-26 16:09:53 +0000
+++ panel/PanelMenuView.cpp	2012-11-30 22:23:21 +0000
@@ -1576,7 +1576,7 @@
   const gchar *title = g_variant_get_string(data, 0);
   _panel_title = (title ? title : "");
 
-  Refresh();
+  Refresh(true);
   QueueDraw();
 }
 

=== modified file 'tests/autopilot/unity/tests/launcher/test_keynav.py'
--- tests/autopilot/unity/tests/launcher/test_keynav.py	2012-09-13 10:56:42 +0000
+++ tests/autopilot/unity/tests/launcher/test_keynav.py	2012-11-30 22:23:21 +0000
@@ -234,3 +234,8 @@
         self.assertThat(self.dash.visible, Eventually(Equals(True)))
         self.assertThat(self.launcher.key_nav_is_active, Eventually(Equals(False)))
 
+    def test_launcher_keynav_changes_panel(self):
+      """The panel title must change when in key nav mode."""
+
+      self.start_keynav_with_cleanup_cancel()
+      self.assertThat(self.panels.get_active_panel().title, Eventually(Equals("Dash Home")))