Code review comment for lp:~brandontschaefer/unity/lp.834465-fix-ABI-BREAK-FIX

Revision history for this message
Marco Trevisan (TreviƱo) (3v1n0) wrote :

I think you should do this inside IMTextEntry instead since it's the lower level class that we share between all the the text fields (not only the search bar, but also the spread filter and lockscreen inputs).

At this point, I think you can avoid to put this inside UnitySettings at all, since I don't think we need to use this setting everywhere else, so I'd just modify that class.

review: Needs Fixing

« Back to merge proposal