Merge lp:~brandontschaefer/unity/lp.1353167-fix into lp:unity
Proposed by
Brandon Schaefer
Status: | Merged |
---|---|
Approved by: | Marco Trevisan (Treviño) |
Approved revision: | no longer in the source branch. |
Merged at revision: | 3853 |
Proposed branch: | lp:~brandontschaefer/unity/lp.1353167-fix |
Merge into: | lp:unity |
Diff against target: |
706 lines (+27/-121) 34 files modified
UnityCore/CheckOptionFilter.cpp (+0/-3) UnityCore/Filter.cpp (+0/-3) UnityCore/MultiRangeFilter.cpp (+0/-3) UnityCore/MusicPreview.cpp (+0/-1) UnityCore/RadioOptionFilter.cpp (+0/-3) UnityCore/Scope.cpp (+6/-0) UnityCore/Scope.h (+2/-7) dash/ScopeBar.cpp (+0/-2) dash/previews/ActionButton.cpp (+0/-2) dash/previews/PreviewContainer.cpp (+0/-2) dash/previews/PreviewInfoHintWidget.cpp (+0/-2) dash/previews/PreviewNavigator.cpp (+0/-2) dash/previews/SocialPreviewComments.cpp (+0/-2) dash/previews/SocialPreviewContent.cpp (+0/-2) dash/previews/Track.cpp (+0/-2) decorations/DecoratedWindow.cpp (+0/-2) decorations/DecorationsInputMixer.cpp (+0/-5) decorations/DecorationsManager.cpp (+0/-3) hud/HudButton.cpp (+0/-2) launcher/LauncherHideMachine.cpp (+0/-4) launcher/SimpleLauncherIcon.cpp (+0/-4) launcher/VolumeLauncherIcon.cpp (+0/-2) panel/PanelController.cpp (+0/-2) panel/PanelView.cpp (+0/-3) plugins/unityshell/src/unityshell.cpp (+16/-10) tests/test_glib_object.cpp (+0/-5) tests/test_icon_loader.cpp (+0/-9) tests/test_result_renderer.cpp (+0/-23) unity-shared/OverlayWindowButtons.cpp (+1/-1) unity-shared/OverlayWindowButtons.h (+1/-1) unity-shared/StandaloneAppManager.cpp (+0/-2) unity-shared/StandaloneWindowManager.cpp (+0/-3) unity-shared/TextureCache.cpp (+0/-2) unity-shared/UBusServer.cpp (+1/-2) |
To merge this branch: | bzr merge lp:~brandontschaefer/unity/lp.1353167-fix |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
PS Jenkins bot (community) | continuous-integration | Approve | |
Marco Trevisan (Treviño) | Approve | ||
Review via email: mp+229708@code.launchpad.net |
Commit message
Make sure we check if the Quicklist or Alt+F1 key nav is open (so we can close them)
Bore checking if something as a WM grab. As we cant open the hud is in Quicklist or KeyNav anymore.
Description of the change
Fixes AP test unity.tests.
It was failing because now with the lockscreen we want to make sure if the WM has any type of grab we don't allow the HUD to come up. This was being checked before the check to see if the Quicklist was open (so we can close it, to allow the hud to come up). Just more the check before the WM grab check and all is well.
To post a comment you must log in.
FAILED: Continuous integration, rev:3847 /code.launchpad .net/~brandonts chaefer/ unity/lp. 1353167- fix/+merge/ 229708/ +edit-commit- message
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https:/
http:// jenkins. qa.ubuntu. com/job/ unity-ci/ 1043/ jenkins. qa.ubuntu. com/job/ unity-utopic- amd64-ci/ 130 jenkins. qa.ubuntu. com/job/ unity-utopic- armhf-ci/ 130 jenkins. qa.ubuntu. com/job/ unity-utopic- i386-ci/ 130
Executed test runs:
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
Click here to trigger a rebuild: s-jenkins. ubuntu- ci:8080/ job/unity- ci/1043/ rebuild
http://