Merge lp:~brandontschaefer/unity/lp.1157329-fix into lp:unity

Proposed by Brandon Schaefer
Status: Rejected
Rejected by: Brandon Schaefer
Proposed branch: lp:~brandontschaefer/unity/lp.1157329-fix
Merge into: lp:unity
Diff against target: 14 lines (+4/-0)
1 file modified
unity-shared/SearchBar.cpp (+4/-0)
To merge this branch: bzr merge lp:~brandontschaefer/unity/lp.1157329-fix
Reviewer Review Type Date Requested Status
Unity Team Pending
Review via email: mp+154229@code.launchpad.net

Commit message

When the SearchBar has changes Geometry (Going to max mode) it will QueueRefresh a layout redraw. This means the text will actually be redrawn vs being drawn over.

Description of the change

To post a comment you must log in.
3235. By Brandon Schaefer

* Comment out unused params

Revision history for this message
Brandon Schaefer (brandontschaefer) wrote :

Marco had such a better idea :), just fix it in nux. Rejected!

Unmerged revisions

3235. By Brandon Schaefer

* Comment out unused params

3234. By Brandon Schaefer

* On geo change, force redraw of the text.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'unity-shared/SearchBar.cpp'
2--- unity-shared/SearchBar.cpp 2013-03-15 13:44:17 +0000
3+++ unity-shared/SearchBar.cpp 2013-03-20 16:57:26 +0000
4@@ -179,6 +179,10 @@
5 layered_layout_->SetActiveLayerN(1);
6 entry_layout_->AddView(layered_layout_, 1, nux::MINOR_POSITION_CENTER, nux::MINOR_SIZE_FIX);
7
8+ geometry_changed.connect([this] (Area* /*area*/, nux::Geometry& /*geo*/) {
9+ pango_entry_->ForceResetLayout();
10+ });
11+
12 if (show_filter_hint_)
13 {
14 std::string filter_str(_("Filter results"));