lp:~brandontschaefer/unity/lp.1101310-fix-launcher-resize-window-buttons

Branch merges

Propose for merging

No branches dependent on this one.

Rejected for merging into lp:unity

Unity Team: Pending requested 2013-01-28

Diff: 2131 lines (+1015/-845)

20 files modified

dash/CMakeLists.txt (+1/-1)
dash/DashView.cpp (+17/-9)
dash/DashView.h (+12/-7)
hud/CMakeLists.txt (+1/-1)
hud/HudView.cpp (+6/-0)
hud/HudView.h (+3/-0)
panel/CMakeLists.txt (+0/-1)
panel/PanelMenuView.cpp (+2/-1)
panel/PanelMenuView.h (+1/-1)
panel/WindowButtonPriv.h (+0/-84)
panel/WindowButtons.cpp (+0/-662)
panel/WindowButtons.h (+0/-76)
tests/autopilot/unity/tests/test_panel.py (+16/-0)
tests/test_window_buttons.cpp (+2/-2)
unity-shared/CMakeLists.txt (+2/-0)
unity-shared/OverlayWindowButtons.cpp (+76/-0)
unity-shared/OverlayWindowButtons.h (+53/-0)
unity-shared/WindowButtonPriv.h (+84/-0)
unity-shared/WindowButtons.cpp (+662/-0)
unity-shared/WindowButtons.h (+77/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1101310: [staging][raring] Dash Maximise/Restore button depends on the launcher icon size.

High

Fix Released

Link a bug report

Related blueprints

3070. By Brandon Schaefer on 2013-01-28

* The main reason, is the DashView has to take up the PanelHeight, so when the
  launcher icons are resized, part of the window buttons get cut off from mouse events.
* Move WindowButtons over to unity-shared, it is now shared between the dash/hud/panel
* Created a class OverlayWindowButtons which will sit in the DashView/HudView
  to handle mouse events for the window buttons.
* TODO: We need to refactor the PanelMenuView to extract window button logic
  (dealing with overlays).

3069. By Marco Trevisan (Treviño) on 2013-01-24

TestShortcutController: add more tests for listened signals.

Approved by Stephen M. Webb.

3068. By Thomi Richards on 2013-01-24

Remove code that calls Introspection node destructors explicitly.

Approved by Nick Dedekind.

3067. By Marco Trevisan (Treviño) on 2013-01-24

TestUtils: fix false-expected tests with lambda functions, remove code duplication, use better defaults.

Approved by Stephen M. Webb.

3066. By Brandon Schaefer on 2013-01-24

Fixes a bunch of base window leaks in the unit tests, which was causes a crash. This also fixes a shortcut controller crash. Fixes: https://bugs.launchpad.net/bugs/1102699.

Approved by Marco Trevisan (Treviño), Andrea Azzarone.

3065. By Stephen M. Webb on 2013-01-24

Make the private impemntation of the Switcher::Controller private.

Approved by Łukasz Zemczak, Brandon Schaefer.

3064. By Marco Trevisan (Treviño) on 2013-01-24

CompizShortcutModeller: listen to WM changes, and update model accordingly, fix View resizes. Fixes: https://bugs.launchpad.net/bugs/1103561.

Approved by Andrea Azzarone, John Lea.

3063. By Łukasz Zemczak on 2013-01-24

Fix HUD, panel and switcher tests to not fail when we have not enough workspaces than needed - simply skip the test instead. Also, change the way workspaces are used. We don't like hardcoding workspace values when not needed.

Approved by Didier Roche.

3062. By Stephen M. Webb on 2013-01-24

Added a new function GetCurrentSelection() to the Switcher.

Approved by Brandon Schaefer.

3061. By Stephen M. Webb on 2013-01-24

Small style changes to make the SwitcherController sources conform to the Unity style guidelines.

Approved by Brandon Schaefer.