Merge lp:~brandontschaefer/unity/lp.1101310-fix-launcher-resize-dash-window-buttons into lp:unity
Status: | Rejected |
---|---|
Rejected by: | Brandon Schaefer |
Proposed branch: | lp:~brandontschaefer/unity/lp.1101310-fix-launcher-resize-dash-window-buttons |
Merge into: | lp:unity |
Diff against target: |
156 lines (+28/-32) 4 files modified
dash/DashController.cpp (+3/-2) dash/DashView.cpp (+8/-29) panel/PanelView.cpp (+2/-1) tests/autopilot/unity/tests/test_panel.py (+15/-0) |
To merge this branch: | bzr merge lp:~brandontschaefer/unity/lp.1101310-fix-launcher-resize-dash-window-buttons |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Andrea Azzarone (community) | Needs Fixing | ||
Review via email: mp+143975@code.launchpad.net |
Commit message
The DashView was taking up the entire screen (minus the launcher). So mouse down events would get eaten by the Dash.
So now we add the panel height to the geo.y of the DashView, so it doesn't eat those events anymore.
Description of the change
=== Problem ===
The DashView was taking up the entire screen (minus the launcher). So mouse down events would get eaten by the Dash.
=== Fix ===
So now we add the panel height to the DashView, so it doesn't eat those anymore!
=== Test ===
AP Test
Unmerged revisions
- 3051. By Brandon Schaefer
-
* Adds an AP test, and fixes a problem with the dash in maxed mode
- 3050. By Brandon Schaefer
-
* Opps, left something in...
- 3049. By Brandon Schaefer
-
* The DashView (Actual Geometry, not content) was taking up the entire screen
(minus the launcher), so now we subtract the panel from that so the nux event
cant reach the window button when the launcher icons are re-sized.
When a preview is shown the blurred dash icons are not drawn on the panel.