Merge lp:~brandontschaefer/unity/lp.1099815-fix into lp:unity

Proposed by Brandon Schaefer
Status: Superseded
Proposed branch: lp:~brandontschaefer/unity/lp.1099815-fix
Merge into: lp:unity
Diff against target: 11 lines (+1/-0)
1 file modified
plugins/unityshell/src/unityshell.cpp (+1/-0)
To merge this branch: bzr merge lp:~brandontschaefer/unity/lp.1099815-fix
Reviewer Review Type Date Requested Status
Unity Team Pending
Review via email: mp+156101@code.launchpad.net

This proposal has been superseded by a proposal from 2013-03-29.

Commit message

Emit options has changed, when the launcher options have changed. So there is no delay while updating the options (mainly on startup).

Description of the change

Emit options has changed, when the launcher options have changed. So there is no delay while updating the options (mainly on startup).

To post a comment you must log in.
Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

Mh, I'm not sure this is the best thing since it bypasses the idle we have in LauncherOptions and that could be ok for the very first change, but the problem is that it also emits the option_changed signal when the values have been not really changed (even if compiz could handle it).

Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

FYI, this is enough to fix this case: http://pastebin.ubuntu.com/5658122/

Unmerged revisions

3257. By Brandon Schaefer

* When the launcher icon size has changed, emit that it has so we can update
  faster.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'plugins/unityshell/src/unityshell.cpp'
2--- plugins/unityshell/src/unityshell.cpp 2013-03-20 01:14:35 +0000
3+++ plugins/unityshell/src/unityshell.cpp 2013-03-29 02:19:22 +0000
4@@ -3044,6 +3044,7 @@
5
6 launcher_options->icon_size = optionGetIconSize();
7 launcher_options->tile_size = optionGetIconSize() + 6;
8+ launcher_options->option_changed.emit();
9
10 hud_controller_->icon_size = launcher_options->icon_size();
11 hud_controller_->tile_size = launcher_options->tile_size();