Merge lp:~brandontschaefer/unity/libnux-bump into lp:unity

Proposed by Brandon Schaefer
Status: Merged
Approved by: Christopher Townsend
Approved revision: no longer in the source branch.
Merged at revision: 3614
Proposed branch: lp:~brandontschaefer/unity/libnux-bump
Merge into: lp:unity
Diff against target: 48 lines (+3/-7)
3 files modified
CMakeLists.txt (+1/-1)
debian/control (+2/-2)
tests/autopilot/unity/tests/xim/test_gcin.py (+0/-4)
To merge this branch: bzr merge lp:~brandontschaefer/unity/libnux-bump
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Christopher Townsend Approve
Review via email: mp+200334@code.launchpad.net

Commit message

Description of the change

Bump to new libnux from this branch:
https://code.launchpad.net/~brandontschaefer/nux/xim-preedit-support

Hopefully I've bumped it correctly!

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Christopher Townsend (townsend) wrote :

I think the version dependency may be a problem. Here's why.

Currently in the daily-build PPA, Nux version 4.0.4+14.04.20131220.1-0ubuntu1 is built but does not include the XIM changes. This version is greater than 4.0.4+14.04.20131203.0-0ubuntu2, so I'm thinking we should bump the Nux version to 4.0.5. That way there is no question on the exact build version (e.g. 14.04.20131220.1) that gets the ABI change.

Also, should also change the Nux version in CMakeLists.txt so compiled versions of Unity will also build against the abi change.

I'll comment in the Nux branch as well about the Nux versioning.

review: Needs Fixing
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Christopher Townsend (townsend) wrote :

This looks good now. Will globally approve once the Nux branch is merged.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'CMakeLists.txt'
2--- CMakeLists.txt 2013-11-07 13:54:18 +0000
3+++ CMakeLists.txt 2014-01-03 17:07:12 +0000
4@@ -230,7 +230,7 @@
5 libbamf3>=0.5.0
6 libnotify
7 libstartup-notification-1.0
8- nux-4.0>=4.0.4
9+ nux-4.0>=4.0.5
10 sigc++-2.0
11 unity-misc>=0.4.0
12 xpathselect=1.4
13
14=== modified file 'debian/control'
15--- debian/control 2013-12-02 19:08:01 +0000
16+++ debian/control 2014-01-03 17:07:12 +0000
17@@ -36,7 +36,7 @@
18 libnih-dbus-dev,
19 libnih-dev,
20 libnotify-dev,
21- libnux-4.0-dev (>= 4.0.4),
22+ libnux-4.0-dev (>= 4.0.5),
23 libpango1.0-dev,
24 libsigc++-2.0-dev,
25 libstartup-notification0-dev,
26@@ -148,7 +148,7 @@
27 libunity-core-6.0-8 (= ${binary:Version}),
28 libglib2.0-dev,
29 libsigc++-2.0-dev,
30- libnux-4.0-dev (>= 4.0.4),
31+ libnux-4.0-dev (>= 4.0.5),
32 libunity-dev (>= 7.1.0~),
33 libdee-dev,
34 Description: Core library for the Unity interface - development files
35
36=== modified file 'tests/autopilot/unity/tests/xim/test_gcin.py'
37--- tests/autopilot/unity/tests/xim/test_gcin.py 2013-02-04 19:54:47 +0000
38+++ tests/autopilot/unity/tests/xim/test_gcin.py 2014-01-03 17:07:12 +0000
39@@ -30,10 +30,6 @@
40 if 'gcin' not in running_process:
41 self.skip("gcin is not an active process, please start 'gcin' before running these tests.")
42
43- if 'ibus' in running_process:
44- self.skip("IBus is currently running, please close 'ibus-daemon' before running these tests.")
45-
46-
47 class GcinTestHangul(GcinTestCase):
48 """Tests the Dash and Hud with gcin in hangul mode."""
49