Merge lp:~brandontschaefer/unity/fix.885304 into lp:unity
Proposed by
Brandon Schaefer
Status: | Merged |
---|---|
Approved by: | Brandon Schaefer |
Approved revision: | no longer in the source branch. |
Merged at revision: | 2123 |
Proposed branch: | lp:~brandontschaefer/unity/fix.885304 |
Merge into: | lp:unity |
Diff against target: |
86 lines (+43/-2) 3 files modified
plugins/unityshell/src/LauncherController.cpp (+6/-2) plugins/unityshell/src/unityshell.cpp (+5/-0) tests/autopilot/autopilot/tests/test_launcher.py (+32/-0) |
To merge this branch: | bzr merge lp:~brandontschaefer/unity/fix.885304 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Thomi Richards (community) | Approve | ||
Review via email: mp+97781@code.launchpad.net |
Commit message
* Fixes the problem where Alt+F1 wouldn't quit key nav mode. Now it toggles
Description of the change
= Problem description =
Alt is used to exit key nav mode (alt+f1), this means if you hit alt+f1 while in keynav mode it exits keynav mode, then starts it again. This is not the toggling effect wanted.
= The fix =
If alt + <anykey> is pressed then exit keynav mode.
Also if the hud is about to show exit keynav mode
= Test coverage =
There is an autopilot test for this
To post a comment you must log in.
The code looks fine, we should get some autopilot tests around it :)