Merge lp:~brandontschaefer/unity/fix-1246891 into lp:unity

Proposed by Brandon Schaefer
Status: Merged
Approved by: Christopher Townsend
Approved revision: no longer in the source branch.
Merged at revision: 3935
Proposed branch: lp:~brandontschaefer/unity/fix-1246891
Merge into: lp:unity
Diff against target: 25 lines (+9/-5)
1 file modified
launcher/Launcher.cpp (+9/-5)
To merge this branch: bzr merge lp:~brandontschaefer/unity/fix-1246891
Reviewer Review Type Date Requested Status
Christopher Townsend Approve
Review via email: mp+252934@code.launchpad.net

Commit message

When we quit the quicklist it would check if the mouse was over the launcher, if it wasn't it would fold the launcher. We don't need to check this if we are in keynav as we want all the icons to be unfolded.

Description of the change

When we quit the quicklist it would check if the mouse was over the launcher, if it wasnt it would fold the launcher. We dont need to check this if we are in keynav as we want all the icons to be unfolded.

To post a comment you must log in.
Revision history for this message
Christopher Townsend (townsend) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'launcher/Launcher.cpp'
2--- launcher/Launcher.cpp 2014-12-12 22:33:24 +0000
3+++ launcher/Launcher.cpp 2015-03-13 17:51:05 +0000
4@@ -2308,13 +2308,17 @@
5
6 void Launcher::RecvQuicklistClosed(nux::ObjectPtr<QuicklistView> const& quicklist)
7 {
8- nux::Point pt = nux::GetWindowCompositor().GetMousePosition();
9- if (!GetAbsoluteGeometry().IsInside(pt))
10+ if (!IsInKeyNavMode())
11 {
12- // The Quicklist just closed and the mouse is outside the launcher.
13- SetHover(false);
14- SetStateMouseOverLauncher(false);
15+ nux::Point pt = nux::GetWindowCompositor().GetMousePosition();
16+ if (!GetAbsoluteGeometry().IsInside(pt))
17+ {
18+ // The Quicklist just closed and the mouse is outside the launcher.
19+ SetHover(false);
20+ SetStateMouseOverLauncher(false);
21+ }
22 }
23+
24 // Cancel any prior state that was set before the Quicklist appeared.
25 SetActionState(ACTION_NONE);
26