Merge lp:~brandontschaefer/unity/disable-tap-for-super into lp:unity

[Brandon Schaefer]

Disable reliable compiz tap detection for the Super key, so other programs
can still bind to Super+other_keys.
(LP: #950160)

A new option to disable tap detection in compiz. This sets it true for Super/show_launcher key.

Depends on this branch:
https://code.launchpad.net/~brandontschaefer/compiz/disable-tap-detection/+merge/127370

[Daniel van Vugt (vanvugt)]

Looks good to me. But it won't work until you have the requisite compiz change.

review: Approve

[Unity Merger (unity-merger)]

The Jenkins job https://jenkins.qa.ubuntu.com/job/automerge-unity/1457/console reported an error when processing this lp:~brandontschaefer/unity/disable-tap-for-super branch.
Not merging it.

[Unity Merger (unity-merger)]

The Jenkins job https://jenkins.qa.ubuntu.com/job/automerge-unity/1466/console reported an error when processing this lp:~brandontschaefer/unity/disable-tap-for-super branch.
Not merging it.

[Daniel van Vugt (vanvugt)]

Rejected why?

[Daniel van Vugt (vanvugt)]

Hmm seems to be superseded by:
lp:~brandontschaefer/unity/disable-super-tap-detection

[Brandon Schaefer (brandontschaefer)]

Sorry I didn't make a comment. This branch has a criss-cross problem, which messes up/confuses the merger. The easiest thing was just to make a new branch :)

Unmerged revisions

2777. By Brandon Schaefer on 2012-10-02

* Renamed

2776. By Brandon Schaefer on 2012-10-01

* Disable tap detection for the Super key

=== modified file 'plugins/unityshell/src/unityshell.cpp'
=== modified file 'plugins/unityshell/unityshell.xml.in'
--- plugins/unityshell/unityshell.xml.in	2012-09-07 15:49:40 +0000
+++ plugins/unityshell/unityshell.xml.in	2012-10-02 17:06:38 +0000
@@ -79,6 +79,7 @@
                 <option name="show_launcher" type="key">
                     <_short>Key to show the launcher</_short>
                     <_long>Make the launcher appear with that key</_long>
+                    <tap_detection>false</tap_detection>
                     <default>&lt;Super&gt;</default>
                   </option>
                   <option name="keyboard_focus" type="key">