Merge lp:~brandontschaefer/unity/detail-mode-last-active-window-fix-SRU into lp:unity/5.0

[Brandon Schaefer]

The switcher in detail mode will now focus the last active window, instead of the current one. If the current focus window activated the switcher.

=== Problem ===
When going into detail mode the switcher would focus its own window. This means Detail mode would no longer know if the window was currently active. So it would not swap the current window with the last active window.

This also cause detail mode to all of a sudden swap the first and second icon (very annoying)

=== Fix ===
Save the currently active icon type, so when we check if we need to swap icons we know which one it was.

=== Test ===
There is an AP test.

[Tim Penhey (thumper)]

review: Approve

[Unity Merger (unity-merger)]

The Jenkins job https://jenkins.qa.ubuntu.com/job/automerge-unity/1057/console reported an error when processing this lp:~brandontschaefer/unity/detail-mode-last-active-window-fix-SRU branch.
Not merging it.

[Unity Merger (unity-merger)]

The Jenkins job https://jenkins.qa.ubuntu.com/job/automerge-unity/1077/console reported an error when processing this lp:~brandontschaefer/unity/detail-mode-last-active-window-fix-SRU branch.
Not merging it.

=== modified file 'plugins/unityshell/src/SwitcherModel.cpp'
--- plugins/unityshell/src/SwitcherModel.cpp	2012-03-14 06:24:18 +0000
+++ plugins/unityshell/src/SwitcherModel.cpp	2012-08-15 21:32:21 +0000
@@ -42,6 +42,8 @@
   for (auto icon : _inner)
   {
     AddChild(icon.GetPointer());
+    if (icon->GetQuirk(AbstractLauncherIcon::QUIRK_ACTIVE))
+      _last_active_icon = icon;
   }
 }
 
@@ -156,7 +158,7 @@
   std::sort (results.begin (), results.end (), &CompareWindowsByActive);
 
   // swap so we focus the last focused window first
-  if (Selection()->GetQuirk (AbstractLauncherIcon::QUIRK_ACTIVE) && results.size () > 1)
+  if (Selection() == _last_active_icon && results.size() > 1)
     std::swap (results[0], results[1]);
 
   return results;
@@ -170,7 +172,7 @@
 
   if (detail_selection_index > DetailXids().size() - 1)
     return 0;
- 
+
   return DetailXids()[detail_selection_index];
 }
 

=== modified file 'plugins/unityshell/src/SwitcherModel.h'
--- plugins/unityshell/src/SwitcherModel.h	2012-03-14 06:24:18 +0000
+++ plugins/unityshell/src/SwitcherModel.h	2012-08-15 21:32:21 +0000
@@ -97,6 +97,8 @@
   Base             _inner;
   unsigned int     _index;
   unsigned int     _last_index;
+
+  launcher::AbstractLauncherIcon::Ptr _last_active_icon;
 };
 
 }

=== modified file 'tests/autopilot/autopilot/tests/test_switcher.py'
--- tests/autopilot/autopilot/tests/test_switcher.py	2012-06-25 23:18:15 +0000
+++ tests/autopilot/autopilot/tests/test_switcher.py	2012-08-15 21:32:21 +0000
@@ -364,6 +364,23 @@
         self.switcher.next_icon()
         self.assertThat(self.switcher.get_selection_index(), Equals(0))
 
+    def test_detail_mode_selects_last_active_window(self):
+        """Entering details mode must focus the last focused
+         window of the same application type.
+         """
+
+        app_char1 = self.start_app("Character Map")
+        [char_win1] = app_char1.get_windows()
+
+        self.start_app("Character Map")
+
+        self.switcher.initiate()
+        self.keyboard.press_and_release(self.initiate_keycode)
+        sleep(0.5)
+        self.switcher.stop()
+
+        self.assertTrue(char_win1.is_focused)
+
 
 class SwitcherWorkspaceTests(AutopilotTestCase):
     """Test Switcher behavior with respect to multiple workspaces."""