Unity

Merge lp:~brandontschaefer/unity/decor-dynamic-hi-dpi into lp:unity

  1. decor-dynamic-hi-dpi
  2. Merge into trunk
Proposed by Brandon Schaefer
Status: Merged
Approved by: Stephen M. Webb
Approved revision: no longer in the source branch.
Merged at revision: 3671
Proposed branch: lp:~brandontschaefer/unity/decor-dynamic-hi-dpi
Merge into: lp:unity
Prerequisite: lp:~brandontschaefer/unity/quicklist-dynamic-hdpi-reszie
Diff against target: 0 lines
To merge this branch: bzr merge lp:~brandontschaefer/unity/decor-dynamic-hi-dpi
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Marco Trevisan (Treviño) Approve
Review via email: mp+206837@code.launchpad.net

This proposal supersedes a proposal from 2014-02-18.

Commit message

The decor now scales with the DPI value.

Description of the change

The decor now scales with the DPI value.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:3915
http://jenkins.qa.ubuntu.com/job/unity-ci/654/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-trusty-amd64-ci/190
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-trusty-armhf-ci/186
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-trusty-i386-ci/188

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-ci/654/rebuild

review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:3916
http://jenkins.qa.ubuntu.com/job/unity-ci/657/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-trusty-amd64-ci/193
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-trusty-armhf-ci/189
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-trusty-i386-ci/191

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-ci/657/rebuild

review: Approve (continuous-integration)
Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

76 + nux::Property<int> monitor;

Do we need a public property for this? It doesn't seem to be the case from what I see, so I'd just go for a Window::Impl private monitor_.

Other than that it seems good!

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:3917
http://jenkins.qa.ubuntu.com/job/unity-ci/666/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-trusty-amd64-ci/202/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-trusty-armhf-ci/198
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-trusty-i386-ci/200

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-ci/666/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

I'm about to change that in an upcoming branch, thanks!

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:3918
http://jenkins.qa.ubuntu.com/job/unity-ci/669/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-trusty-amd64-ci/205/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-trusty-armhf-ci/201
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-trusty-i386-ci/203

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-ci/669/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:3919
http://jenkins.qa.ubuntu.com/job/unity-ci/671/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-trusty-amd64-ci/207/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-trusty-armhf-ci/203/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-trusty-i386-ci/205/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-ci/671/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:3920
http://jenkins.qa.ubuntu.com/job/unity-ci/673/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-trusty-amd64-ci/209/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-trusty-armhf-ci/205/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-trusty-i386-ci/207/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-ci/673/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:3921
http://jenkins.qa.ubuntu.com/job/unity-ci/679/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-trusty-amd64-ci/215
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-trusty-armhf-ci/211
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-trusty-i386-ci/213

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-ci/679/rebuild

review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:3922
http://jenkins.qa.ubuntu.com/job/unity-ci/683/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-trusty-amd64-ci/219
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-trusty-armhf-ci/215
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-trusty-i386-ci/217

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-ci/683/rebuild

review: Approve (continuous-integration)

Preview Diff

Empty