Merge lp:~brandontschaefer/unity/dash-root-reference-error-fix into lp:unity/phablet

Proposed by Brandon Schaefer
Status: Rejected
Rejected by: Brandon Schaefer
Proposed branch: lp:~brandontschaefer/unity/dash-root-reference-error-fix
Merge into: lp:unity/phablet
Diff against target: 37 lines (+3/-3)
3 files modified
Dash/DashMusic.qml (+1/-1)
Dash/DashPeople.qml (+1/-1)
Dash/DashVideos.qml (+1/-1)
To merge this branch: bzr merge lp:~brandontschaefer/unity/dash-root-reference-error-fix
Reviewer Review Type Date Requested Status
Unity Team Pending
Review via email: mp+157233@code.launchpad.net

Commit message

Fixes these 3 errors.
    Dash/DashVideos.qml:142: ReferenceError: root is not defined
    Dash/DashMusic.qml:94: ReferenceError: root is not defined
    Dash/DashPeople.qml:118: ReferenceError: root is not defined

Description of the change

Fixes these 3 errors.
    Dash/DashVideos.qml:142: ReferenceError: root is not defined
    Dash/DashMusic.qml:94: ReferenceError: root is not defined
    Dash/DashPeople.qml:118: ReferenceError: root is not defined

The only place I saw a property searchHistroy was under LensView, so I assumed thats what was suppose to be used.

To post a comment you must log in.
Revision history for this message
Brandon Schaefer (brandontschaefer) wrote :

Actually looks like this causes more errors...in:
Components/PageHeader.qml:117: TypeError: Cannot read property 'count' of null

Sooo rejecting branch...

Unmerged revisions

536. By Brandon Schaefer

* Fixes these 3 errors.
Dash/DashVideos.qml:142: ReferenceError: root is not defined
Dash/DashMusic.qml:94: ReferenceError: root is not defined
Dash/DashPeople.qml:118: ReferenceError: root is not defined

* The only place I saw search histroy was under LensView, so I assumed thats
  what was suppose to be used.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'Dash/DashMusic.qml'
2--- Dash/DashMusic.qml 2013-03-19 12:00:47 +0000
3+++ Dash/DashMusic.qml 2013-04-04 21:20:30 +0000
4@@ -91,7 +91,7 @@
5 width: categoryView.width
6 text: "Music"
7 searchEntryEnabled: true
8- searchHistory: root.searchHistory
9+ searchHistory: lensView.searchHistory
10 }
11 }
12 }
13
14=== modified file 'Dash/DashPeople.qml'
15--- Dash/DashPeople.qml 2013-03-19 12:00:47 +0000
16+++ Dash/DashPeople.qml 2013-04-04 21:20:30 +0000
17@@ -115,7 +115,7 @@
18 width: categoryView.width
19 text: "People"
20 searchEntryEnabled: true
21- searchHistory: root.searchHistory
22+ searchHistory: lensView.searchHistory
23 }
24 }
25
26
27=== modified file 'Dash/DashVideos.qml'
28--- Dash/DashVideos.qml 2013-03-19 12:00:47 +0000
29+++ Dash/DashVideos.qml 2013-04-04 21:20:30 +0000
30@@ -139,7 +139,7 @@
31 width: categoryView.width
32 text: "Videos"
33 searchEntryEnabled: true
34- searchHistory: root.searchHistory
35+ searchHistory: lensView.searchHistory
36 }
37 }
38

Subscribers

People subscribed via source and target branches