Merge lp:~brandontschaefer/unity/dash-root-reference-error-fix into lp:unity/phablet
Status: | Rejected |
---|---|
Rejected by: | Brandon Schaefer |
Proposed branch: | lp:~brandontschaefer/unity/dash-root-reference-error-fix |
Merge into: | lp:unity/phablet |
Diff against target: |
37 lines (+3/-3) 3 files modified
Dash/DashMusic.qml (+1/-1) Dash/DashPeople.qml (+1/-1) Dash/DashVideos.qml (+1/-1) |
To merge this branch: | bzr merge lp:~brandontschaefer/unity/dash-root-reference-error-fix |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Unity Team | Pending | ||
Review via email: mp+157233@code.launchpad.net |
Commit message
Fixes these 3 errors.
Dash/
Dash/
Dash/
Description of the change
Fixes these 3 errors.
Dash/
Dash/
Dash/
The only place I saw a property searchHistroy was under LensView, so I assumed thats what was suppose to be used.
Unmerged revisions
- 536. By Brandon Schaefer
-
* Fixes these 3 errors.
Dash/DashVideos.qml:142: ReferenceError: root is not defined
Dash/DashMusic.qml:94: ReferenceError: root is not defined
Dash/DashPeople.qml:118: ReferenceError: root is not defined * The only place I saw search histroy was under LensView, so I assumed thats
what was suppose to be used.
Actually looks like this causes more errors...in: PageHeader. qml:117: TypeError: Cannot read property 'count' of null
Components/
Sooo rejecting branch...