Merge lp:~brandontschaefer/unity/click-boarder-must-not-close-dash-6.0 into lp:unity/6.0

Proposed by Brandon Schaefer
Status: Merged
Approved by: Tim Penhey
Approved revision: 2723
Merge reported by: Neil J. Patel
Merged at revision: not available
Proposed branch: lp:~brandontschaefer/unity/click-boarder-must-not-close-dash-6.0
Merge into: lp:unity/6.0
Diff against target: 25 lines (+7/-1)
1 file modified
dash/DashController.cpp (+7/-1)
To merge this branch: bzr merge lp:~brandontschaefer/unity/click-boarder-must-not-close-dash-6.0
Reviewer Review Type Date Requested Status
Tim Penhey (community) Approve
Review via email: mp+125404@code.launchpad.net

Commit message

Clicking on the Dashs boarder no longer closes it.

Description of the change

=== Problem ===
With new changes to the Dashs geo you could click on the dash boarder which caused it to close.

=== Fix ===
Add the boarder the the geo when checking the input window of the Dash

=== Test ===
This fixes a failing AP test

To post a comment you must log in.
Revision history for this message
Tim Penhey (thumper) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'dash/DashController.cpp'
2--- dash/DashController.cpp 2012-09-19 08:02:20 +0000
3+++ dash/DashController.cpp 2012-09-20 03:42:30 +0000
4@@ -24,6 +24,7 @@
5
6 #include "unity-shared/UnitySettings.h"
7 #include "unity-shared/PanelStyle.h"
8+#include "unity-shared/DashStyle.h"
9 #include "unity-shared/PluginAdapter.h"
10 #include "unity-shared/UBusMessages.h"
11 #include "unity-shared/UScreen.h"
12@@ -457,9 +458,14 @@
13 nux::Geometry Controller::GetInputWindowGeometry()
14 {
15 EnsureDash();
16+ dash::Style& style = dash::Style::Instance();
17 nux::Geometry const& window_geo(window_->GetGeometry());
18 nux::Geometry const& view_content_geo(view_->GetContentGeometry());
19- return nux::Geometry(window_geo.x, window_geo.y, view_content_geo.width, view_content_geo.height);
20+
21+ nux::Geometry geo(window_geo.x, window_geo.y, view_content_geo.width, view_content_geo.height);
22+ geo.width += style.GetDashRightTileWidth();
23+ geo.height += style.GetDashBottomTileHeight();
24+ return geo;
25 }
26
27

Subscribers

People subscribed via source and target branches