Merge lp:~brandontschaefer/unity/alt-tab-mouse-fixes into lp:unity

[Brandon Schaefer]

Make sure we ignore mouse movement over detail icons if the mouse starts over it at start. Let the mouse take selection control once it moves outside of any icon, vs having to enter a different icon.

Couple small fixes:

- Make sure we ignore mouse movement over detail icons if the mouse starts over it at start.
- Let the mouse take selection control once it moves outside of any icon, vs having to enter a different icon.

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:3492
http://jenkins.qa.ubuntu.com/job/unity-ci/339/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-saucy-amd64-ci/228
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-saucy-armhf-ci/226
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-saucy-i386-ci/227

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-ci/339/rebuild

review: Approve (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:3493
http://jenkins.qa.ubuntu.com/job/unity-ci/340/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-saucy-amd64-ci/229
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-saucy-armhf-ci/227
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-saucy-i386-ci/228

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-ci/340/rebuild

review: Approve (continuous-integration)

[Marco Trevisan (Treviño) (3v1n0)]

I'm not sure we need to fix bug #1223037... While that was important for the normal mode (due to the accordion effect), the detail mode seems different. But I guess design has a better opinion for that.

[Christopher Townsend (townsend)]

I'm going to approve although I have an issue on start of Alt+Tab or Alt+Grave, but I'll open a new bug for that so we can discuss with design if the behavior should change, and if so, how.

review: Approve

[PS Jenkins bot (ps-jenkins)]

FAILED: Autolanding.
More details in the following jenkins job:
http://jenkins.qa.ubuntu.com/job/unity-autolanding/254/
Executed test runs:
    FAILURE: http://s-jenkins:8080/job/generic-cleanup-mbs/2130/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-saucy-amd64-autolanding/210/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-saucy-armhf-autolanding/210/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-saucy-i386-autolanding/210/console

review: Needs Fixing (continuous-integration)

[Brandon Schaefer (brandontschaefer)]

Err... lets try again

[PS Jenkins bot (ps-jenkins)]

FAILED: Autolanding.
More details in the following jenkins job:
http://jenkins.qa.ubuntu.com/job/unity-autolanding/255/
Executed test runs:
    FAILURE: http://s-jenkins:8080/job/generic-cleanup-mbs/2133/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-saucy-amd64-autolanding/211/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-saucy-armhf-autolanding/211/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-saucy-i386-autolanding/211/console

review: Needs Fixing (continuous-integration)

[Christopher Townsend (townsend)]

Re-approving now that the Jenkins C-I failures are now fixed in trunk.

[PS Jenkins bot (ps-jenkins)]

review: Approve (continuous-integration)

=== modified file 'launcher/SwitcherView.cpp'
--- launcher/SwitcherView.cpp	2013-09-05 16:51:12 +0000
+++ launcher/SwitcherView.cpp	2013-09-09 23:20:22 +0000
@@ -251,11 +251,22 @@
   nux::Point const& mouse_pos = CalculateMouseMonitorOffset(x, y);
   int detail_icon_index = DetailIconIdexAt(mouse_pos.x, mouse_pos.y);
 
+  if (check_mouse_first_time_)
+  {
+    last_detail_icon_selected_ = detail_icon_index;
+    check_mouse_first_time_ = false;
+    return;
+  }
+
   if (detail_icon_index >= 0 && detail_icon_index != last_detail_icon_selected_)
   {
     model_->detail_selection_index = detail_icon_index;
     last_detail_icon_selected_ = detail_icon_index;
   }
+  else if (detail_icon_index < 0)
+  {
+    last_detail_icon_selected_ = -1;
+  }
 }
 
 void SwitcherView::HandleMouseMove(int x, int y)
@@ -283,6 +294,10 @@
 
     switcher_mouse_move.emit(icon_index);
   }
+  else if (icon_index < 0)
+  {
+    last_icon_selected_ = -1;
+  }
 }
 
 void SwitcherView::RecvMouseDown(int x, int y, unsigned long button_flags, unsigned long /*key_flags*/)