Merge lp:~brandontschaefer/unity/alt-grave-ordering-fix into lp:unity
Proposed by
Brandon Schaefer
Status: | Merged |
---|---|
Approved by: | Marco Trevisan (Treviño) |
Approved revision: | no longer in the source branch. |
Merged at revision: | 2827 |
Proposed branch: | lp:~brandontschaefer/unity/alt-grave-ordering-fix |
Merge into: | lp:unity |
Diff against target: |
85 lines (+52/-2) 3 files modified
launcher/SwitcherModel.cpp (+6/-2) tests/autopilot/unity/tests/test_switcher.py (+13/-0) tests/test_switcher_model.cpp (+33/-0) |
To merge this branch: | bzr merge lp:~brandontschaefer/unity/alt-grave-ordering-fix |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Marco Trevisan (Treviño) | Approve | ||
Thomi Richards (community) | quality | Approve | |
jenkins | continuous-integration | Pending | |
Review via email: mp+128823@code.launchpad.net |
Commit message
Changes the swapping order of the detail mode. Now the currently active window gets moved to the end, instead of getting swapped with the last used window.
Description of the change
=== Problem ===
When pressing Alt+grave twice it would focus the active window going into detail mode. It should focus the third window, not the first.
=== Fix ===
Instead of swapping the first and second window, move the first all the way to the end (it being a vector means moving everything over one left)
=== Test ===
AP test
So with this change:
Window order, where 1 is the current focused window:
1,2,3,4,5,6
Pressing Alt+`
Desired result order:
2,3,4,5,6,1
Current result order:
2,1,3,4,5,6
To post a comment you must log in.
Running:
autopilot run unity.tests. test_switcher
Ran 54 tests in 461.457s
OK