Mir

Code review comment for lp:~brandontschaefer/mir/update-pointer-confinement-v2

Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

+std::string rectangle_to_string(geom::Rectangle const& rect)
+{
+ std::stringstream ss;
+ ss << "{"
+ << rect.top_left.x.as_int() << ", "
+ << rect.top_left.y.as_int() << ", "
+ << rect.size.width.as_int() << ", "
+ << rect.size.height.as_int()
+ << "}";
+
+ return ss.str();
+}
...
+ << " out_rect=" << rectangle_to_string(out_rect);

We have std::ostream& operator<<(std::ostream& out, Rectangle const& value); in /usr/include/mircommon/mir/geometry/rectangle.h. So all the above could be:

  << " out_rect=" << out_rect;

review: Needs Fixing

« Back to merge proposal