Mir

Code review comment for lp:~brandontschaefer/mir/update-pointer-confinement-v2

Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

I do like the idea of a seat report as these events can be helpful in understanding system behaviour but:

1. I think it ought to report all the seat "events", not just confinement region.
2. I think the default should be a NullObject
3. Logging output ought to be a command-line option (as with other reports)
4. I don't know if the events are worth including in LTTNG

review: Needs Fixing

« Back to merge proposal