Mir

Merge lp:~brandontschaefer/mir/libmircookie-dev-needs-nettle into lp:mir

Proposed by Brandon Schaefer on 2015-11-04
Status: Merged
Approved by: Brandon Schaefer on 2015-11-05
Approved revision: 3085
Merged at revision: 3092
Proposed branch: lp:~brandontschaefer/mir/libmircookie-dev-needs-nettle
Merge into: lp:mir
Diff against target: 11 lines (+1/-0)
1 file modified
debian/control (+1/-0)
To merge this branch: bzr merge lp:~brandontschaefer/mir/libmircookie-dev-needs-nettle
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve on 2015-11-06
Kevin DuBois (community) Approve on 2015-11-05
Alberto Aguirre (community) Approve on 2015-11-04
Michał Sawicz 2015-11-04 Approve on 2015-11-04
Review via email: mp+276688@code.launchpad.net

Commit message

Add missing shlibs:Depends entry to libmircookie1 package dependency list

Description of the change

Add missing shlibs:Depends entry to libmircookie1 package dependency list

To post a comment you must log in.
Michał Sawicz (saviq) wrote :

Yes please.

review: Approve
Alberto Aguirre (albaguirre) wrote :

OK.

review: Approve
Alberto Aguirre (albaguirre) wrote :

Actually why is this needed?

The headers in libmircookie-dev do not expose nettle types and does not have #includes.

What is the dep failure here?

review: Needs Information
Alberto Aguirre (albaguirre) wrote :

Correction above: does not have nettle #includes in the mircookie headers

Brandon Schaefer (brandontschaefer) wrote :

Yeah, so we dont *expose* any nettle bits, we shouldnt need this?

Alberto Aguirre (albaguirre) wrote :

It seems the actual root cause is the package libmircookie1 should have a Depends: ${shlibs:Depends} entry.

Alberto Aguirre (albaguirre) wrote :

LGTM.

review: Approve
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Autolanding.
Approved revid is not set in launchpad. This is most likely a launchpad issue and re-approve should fix it. There is also a chance (although a very small one) this is a permission problem of the ps-jenkins bot.
http://jenkins.qa.ubuntu.com/job/mir-autolanding/2085/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-android-vivid-i386-build/4797
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-clang-vivid-amd64-build/3704
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-vivid-touch/4739
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-wily-touch/697/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-wily-amd64-autolanding/640
        deb: http://jenkins.qa.ubuntu.com/job/mir-wily-amd64-autolanding/640/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-wily-i386-ci/697
        deb: http://jenkins.qa.ubuntu.com/job/mir-wily-i386-ci/697/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/4740
        deb: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/4740/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-runner-touch/7344
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/24914
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-wily-armhf/698/console

review: Needs Fixing (continuous-integration)
Kevin DuBois (kdub) wrote :

late to the approval party, but lgtm too

review: Approve
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/control'
2--- debian/control 2015-11-04 07:43:28 +0000
3+++ debian/control 2015-11-04 22:34:37 +0000
4@@ -425,6 +425,7 @@
5 Multi-Arch: same
6 Pre-Depends: ${misc:Pre-Depends}
7 Depends: ${misc:Depends},
8+ ${shlibs:Depends},
9 Description: Produce and verify spoof-resistant timestamps - runtime library
10 libmircookie provides a simple mechanism for a group of cooperating processes
11 to hand out and verify difficult-to-forge timestamps to untrusted 3rd parties.

Subscribers

People subscribed via source and target branches