Merge lp:~brandontschaefer/mir/libmircookie-dev-needs-nettle into lp:mir
| Status: | Merged |
|---|---|
| Approved by: | Brandon Schaefer on 2015-11-05 |
| Approved revision: | 3085 |
| Merged at revision: | 3092 |
| Proposed branch: | lp:~brandontschaefer/mir/libmircookie-dev-needs-nettle |
| Merge into: | lp:mir |
| Diff against target: |
11 lines (+1/-0) 1 file modified
debian/control (+1/-0) |
| To merge this branch: | bzr merge lp:~brandontschaefer/mir/libmircookie-dev-needs-nettle |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| PS Jenkins bot | continuous-integration | Approve on 2015-11-06 | |
| Kevin DuBois (community) | Approve on 2015-11-05 | ||
| Alberto Aguirre | Approve on 2015-11-04 | ||
| Michał Sawicz | 2015-11-04 | Approve on 2015-11-04 | |
|
Review via email:
|
|||
Commit Message
Add missing shlibs:Depends entry to libmircookie1 package dependency list
Description of the Change
Add missing shlibs:Depends entry to libmircookie1 package dependency list
| Alberto Aguirre (albaguirre) wrote : | # |
Actually why is this needed?
The headers in libmircookie-dev do not expose nettle types and does not have #includes.
What is the dep failure here?
| Alberto Aguirre (albaguirre) wrote : | # |
Correction above: does not have nettle #includes in the mircookie headers
| Brandon Schaefer (brandontschaefer) wrote : | # |
Yeah, so we dont *expose* any nettle bits, we shouldnt need this?
| Alberto Aguirre (albaguirre) wrote : | # |
It seems the actual root cause is the package libmircookie1 should have a Depends: ${shlibs:Depends} entry.
| PS Jenkins bot (ps-jenkins) wrote : | # |
PASSED: Continuous integration, rev:3084
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
FAILURE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
SUCCESS: http://
FAILURE: http://
Click here to trigger a rebuild:
http://
| PS Jenkins bot (ps-jenkins) wrote : | # |
PASSED: Continuous integration, rev:3085
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
FAILURE: http://
SUCCESS: http://
deb: http://
FAILURE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
SUCCESS: http://
FAILURE: http://
Click here to trigger a rebuild:
http://
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Autolanding.
Approved revid is not set in launchpad. This is most likely a launchpad issue and re-approve should fix it. There is also a chance (although a very small one) this is a permission problem of the ps-jenkins bot.
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
FAILURE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
SUCCESS: http://
FAILURE: http://
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Autolanding.
More details in the following jenkins job:
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
FAILURE: http://
FAILURE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
deb: http://
FAILURE: http://
SUCCESS: http://
FAILURE: http://
Yes please.